Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 Ambiguity of New Workspace option & 🚀 new Settings option #16540

Merged
merged 2 commits into from
Feb 27, 2023

Conversation

Siddhant-K-code
Copy link
Member

@Siddhant-K-code Siddhant-K-code commented Feb 23, 2023

Description

🔧 Ambiguity of New Workspace ... option & 🚀 new Settings option in Project List Item

Related Issue(s)

Fixes Internal Conversastion

How to test

  • Open Preview
  • Go to /projects
  • And Click Menu Item (Three dots) of any Project. See 👀
    • New Settings option
    • Modified New Workspace ...

Release Notes

NONE

Documentation

Build Options:

  • /werft with-github-actions
    Experimental feature to run the build with GitHub Actions (and not in Werft).
  • leeway-no-cache
    leeway-target=components:all
  • /werft no-test
    Run Leeway with --dont-test
Publish Options
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer Options
  • with-ee-license
  • with-slow-database
  • with-dedicated-emulation
  • with-ws-manager-mk2
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated

Preview Environment Options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh

Signed-off-by: Siddhant Khare [email protected]

@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-chore-projects-items.1 because the annotations in the pull request description changed
(with .werft/ from main)

@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Feb 23, 2023
@Siddhant-K-code
Copy link
Member Author

Siddhant-K-code commented Feb 23, 2023

/werft run with-clean-slate-deployment

👍 started the job as gitpod-build-chore-projects-items.2
(with .werft/ from main)

Signed-off-by: Siddhant Khare <[email protected]>
@Siddhant-K-code
Copy link
Member Author

Siddhant-K-code commented Feb 24, 2023

🤔 🤷🏽‍♂️

Screen.Recording.2023-02-24.at.9.44.06.AM.mov

@geropl
Copy link
Member

geropl commented Feb 24, 2023

Currently seeing this:
image

Could you do a rebase @Siddhant-K-code ? 🙏

@Siddhant-K-code
Copy link
Member Author

Siddhant-K-code commented Feb 24, 2023

@geropl Done ✅

Copy link
Member

@easyCZ easyCZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

/hold in case you want feedback from design

@roboquat roboquat merged commit 105bce3 into main Feb 27, 2023
@roboquat roboquat deleted the chore/projects-items branch February 27, 2023 06:35
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Feb 27, 2023
@Siddhant-K-code
Copy link
Member Author

Siddhant-K-code commented Feb 27, 2023

@easyCZ @geropl Settings doesn't seem to be working in Production also 🤔

Screen.Recording.2023-02-27.at.9.24.47.PM.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production do-not-merge/hold release-note-none size/XS team: webapp Issue belongs to the WebApp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants