Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ws-daemon] Finalise cgroup v2 switch #16500

Merged
merged 2 commits into from
Feb 22, 2023
Merged

[ws-daemon] Finalise cgroup v2 switch #16500

merged 2 commits into from
Feb 22, 2023

Conversation

csweichel
Copy link
Contributor

@csweichel csweichel commented Feb 21, 2023

Description

We've been running on cgroup v2 for a while now, and any Gitpod installation on cgroup v1 is indicative of a configuration issue. On cgroup v1 core functionality of Gitpod does not function.

This PR removes the last remnant of cgroupv1 support, and enforces cgroupv2 within ws-daemon.

How to test

Run on a cgroupv1 system and observe ws-daemon failing to start.

Release Notes

Run solely on cgroup v2 systems

Documentation

Build Options:

  • /werft with-github-actions
    Experimental feature to run the build with GitHub Actions (and not in Werft).
  • leeway-no-cache
    leeway-target=components:all
  • /werft no-test
    Run Leeway with --dont-test
Publish Options
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer Options
  • with-ee-license
  • with-slow-database
  • with-dedicated-emulation
  • with-ws-manager-mk2
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated

Preview Environment Options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • /werft with-integration-tests=workspace
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh

@csweichel csweichel requested a review from a team February 21, 2023 19:26
@github-actions github-actions bot added the team: workspace Issue belongs to the Workspace team label Feb 21, 2023
@csweichel
Copy link
Contributor Author

/hold

@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-cw-cgroupv2.2 because the annotations in the pull request description changed
(with .werft/ from main)

@csweichel
Copy link
Contributor Author

csweichel commented Feb 22, 2023

/werft run

👍 started the job as gitpod-build-cw-cgroupv2.3
(with .werft/ from main)

@csweichel
Copy link
Contributor Author

/hold cancel

@aledbf
Copy link
Member

aledbf commented Feb 22, 2023

/hold cancel

@roboquat roboquat merged commit 0442b46 into main Feb 22, 2023
@roboquat roboquat deleted the cw/cgroupv2 branch February 22, 2023 13:27
@roboquat roboquat added deployed: workspace Workspace team change is running in production deployed Change is completely running in production labels Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: workspace Workspace team change is running in production deployed Change is completely running in production release-note size/L team: workspace Issue belongs to the Workspace team
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants