Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[workspace] change iface name to eth0 #16368

Merged
merged 1 commit into from
Feb 20, 2023
Merged

[workspace] change iface name to eth0 #16368

merged 1 commit into from
Feb 20, 2023

Conversation

iQQBot
Copy link
Contributor

@iQQBot iQQBot commented Feb 13, 2023

Description

[workspace] change iface name to eth0

part of #16363

Related Issue(s)

Fixes #

How to test

Test in #16363

Release Notes

NONE

Documentation

Build Options:

  • /werft with-github-actions
    Experimental feature to run the build with GitHub Actions (and not in Werft).
  • leeway-no-cache
    leeway-target=components:all
  • /werft no-test
    Run Leeway with --dont-test
Publish Options
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer Options
  • with-ee-license
  • with-slow-database
  • with-dedicated-emulation
  • with-ws-manager-mk2
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated

Preview Environment Options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • /werft with-integration-tests=workspace
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh

@iQQBot iQQBot requested a review from a team February 13, 2023 09:57
@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-pd-docker-up-1.1 because the annotations in the pull request description changed
(with .werft/ from main)

@github-actions github-actions bot added the team: workspace Issue belongs to the Workspace team label Feb 13, 2023
@roboquat roboquat added size/XS and removed size/S labels Feb 13, 2023
@iQQBot
Copy link
Contributor Author

iQQBot commented Feb 14, 2023

could someone from @gitpod-io/engineering-workspace review this PR?

@iQQBot iQQBot changed the title [docker-up] support customize data root and iface name [workspace] change iface name to eth0 Feb 20, 2023
@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-pd-docker-up-1.3 because the annotations in the pull request description changed
(with .werft/ from main)

@kylos101
Copy link
Contributor

kylos101 commented Feb 20, 2023

/werft run with-integration-tests=workspace with-large-vm=true

👍 started the job as gitpod-build-pd-docker-up-1.4
(with .werft/ from main)

@akosyakov
Copy link
Member

@Furisto I've rebased it.

@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-pd-docker-up-1.6 because the annotations in the pull request description changed
(with .werft/ from main)

@roboquat roboquat merged commit 40830a8 into main Feb 20, 2023
@roboquat roboquat deleted the pd/docker-up-1 branch February 20, 2023 14:05
@aledbf
Copy link
Member

aledbf commented Feb 20, 2023

Someone needs to update the docker compose PR, publish a release and update the code like or docker-compose will break in the next deployment

cc @kylos101

@kylos101
Copy link
Contributor

Thanks @aledbf , I will do soon, appreciate the heads up!

kylos101 added a commit to gitpod-io/compose that referenced this pull request Feb 20, 2023
kylos101 added a commit that referenced this pull request Feb 20, 2023
Context: #16368 (comment)

Release: https://github.com/gitpod-io/compose/releases/tag/v2.10.0-gitpod.1

Also, refactored source of truth for Docker Compose version to WORKSPACE.yaml for consistency and consideration when changing Docker version
@kylos101 kylos101 mentioned this pull request Feb 20, 2023
15 tasks
kylos101 added a commit that referenced this pull request Feb 20, 2023
Context: #16368 (comment)

Related Docker Compose release: https://github.com/gitpod-io/compose/releases/tag/v2.10.0-gitpod.1

Also, refactored source of truth for Docker Compose version to WORKSPACE.yaml for consistency and consideration when changing Docker version
kylos101 added a commit that referenced this pull request Feb 20, 2023
Context: #16368 (comment)

Related Docker Compose release: https://github.com/gitpod-io/compose/releases/tag/v2.10.0-gitpod.1

Also, refactored source of truth for Docker Compose version to WORKSPACE.yaml for consistency and consideration when changing Docker version
kylos101 added a commit that referenced this pull request Feb 20, 2023
Context: #16368 (comment)

Related Docker Compose release: https://github.com/gitpod-io/compose/releases/tag/v2.10.0-gitpod.1

Also, refactored source of truth for Docker Compose version to WORKSPACE.yaml for consistency and consideration when changing Docker version
kylos101 added a commit that referenced this pull request Feb 20, 2023
Context: #16368 (comment)

Related Docker Compose release: https://github.com/gitpod-io/compose/releases/tag/v2.10.0-gitpod.1

Also, refactored source of truth for Docker Compose version to WORKSPACE.yaml for consistency and consideration when changing Docker version
kylos101 added a commit that referenced this pull request Feb 20, 2023
Context: #16368 (comment)

Related Docker Compose release: https://github.com/gitpod-io/compose/releases/tag/v2.10.0-gitpod.1

Also, refactored source of truth for Docker Compose version to WORKSPACE.yaml for consistency and consideration when changing Docker version
kylos101 added a commit that referenced this pull request Feb 20, 2023
Context: #16368 (comment)

Related Docker Compose release: https://github.com/gitpod-io/compose/releases/tag/v2.10.0-gitpod.1

Also, refactored source of truth for Docker Compose version to WORKSPACE.yaml for consistency and consideration when changing Docker version
aledbf pushed a commit to gitpod-io/compose that referenced this pull request Feb 21, 2023
roboquat pushed a commit that referenced this pull request Feb 21, 2023
Context: #16368 (comment)

Related Docker Compose release: https://github.com/gitpod-io/compose/releases/tag/v2.10.0-gitpod.1

Also, refactored source of truth for Docker Compose version to WORKSPACE.yaml for consistency and consideration when changing Docker version
@roboquat roboquat added deployed: workspace Workspace team change is running in production deployed Change is completely running in production labels Feb 24, 2023
aledbf pushed a commit to gitpod-io/compose that referenced this pull request Mar 27, 2023
Furisto pushed a commit to gitpod-io/compose that referenced this pull request Apr 26, 2023
kylos101 added a commit to gitpod-io/compose that referenced this pull request May 22, 2023
kylos101 added a commit to gitpod-io/compose that referenced this pull request May 22, 2023
aledbf pushed a commit to gitpod-io/compose that referenced this pull request May 22, 2023
aledbf pushed a commit to gitpod-io/compose that referenced this pull request May 22, 2023
aledbf pushed a commit to gitpod-io/compose that referenced this pull request May 22, 2023
aledbf pushed a commit to gitpod-io/compose that referenced this pull request May 22, 2023
kylos101 added a commit to gitpod-io/compose that referenced this pull request Aug 7, 2023
kylos101 added a commit to gitpod-io/compose that referenced this pull request Aug 7, 2023
kylos101 added a commit to gitpod-io/compose that referenced this pull request Aug 8, 2023
WVerlaek pushed a commit to gitpod-io/compose that referenced this pull request Sep 19, 2023
nandajavarma pushed a commit to gitpod-io/compose that referenced this pull request Oct 31, 2023
nandajavarma pushed a commit to gitpod-io/compose that referenced this pull request Oct 31, 2023
kylos101 added a commit to gitpod-io/compose that referenced this pull request Dec 12, 2023
kylos101 added a commit to gitpod-io/compose that referenced this pull request Dec 12, 2023
kylos101 added a commit to gitpod-io/compose that referenced this pull request Feb 6, 2024
kylos101 added a commit to gitpod-io/compose that referenced this pull request Apr 29, 2024
kylos101 added a commit to gitpod-io/compose that referenced this pull request Apr 29, 2024
geropl pushed a commit to gitpod-io/compose that referenced this pull request Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: workspace Workspace team change is running in production deployed Change is completely running in production release-note-none size/XS team: workspace Issue belongs to the Workspace team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants