Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gitpod-web extension to improve open desktop ide prompt #16321

Merged
merged 1 commit into from
Feb 9, 2023

Conversation

mustard-mh
Copy link
Contributor

@mustard-mh mustard-mh commented Feb 9, 2023

Description

Update gitpod-web extension to improve open desktop ide prompt

Related Issue(s)

Fixes #

How to test

  1. start a workspace using vscode desktop in preview environment
  2. click Open in VSCode Desktop button, check the prompt should direct under preview environment domain.
  3. click Open in browser button, wait vscode load finish, Click left bottom Gitpod icon, select Open in VS Code, check the prompt should direct under preview environment domain.

Release Notes

Improve prompt for `Gitpod: Open in VS Code` action in Browser Code

Documentation

Build Options:

  • /werft with-github-actions
    Experimental feature to run the build with GitHub Actions (and not in Werft).
  • leeway-no-cache
    leeway-target=components:all
  • /werft no-test
    Run Leeway with --dont-test
Publish Options
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer Options
  • with-ee-license
  • with-slow-database
  • with-dedicated-emulation
  • with-ws-manager-mk2
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated

Preview Environment Options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh

@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-hw-gitpod-web-desktop.1 because the annotations in the pull request description changed
(with .werft/ from main)

@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-hw-gitpod-web-desktop.2 because the annotations in the pull request description changed
(with .werft/ from main)

@mustard-mh mustard-mh force-pushed the hw/gitpod-web-desktop branch from 838ef39 to dde7be8 Compare February 9, 2023 15:38
@mustard-mh mustard-mh changed the title update gitpod-web extension to improve open desktop ide prompt Update gitpod-web extension to improve open desktop ide prompt Feb 9, 2023
@mustard-mh
Copy link
Contributor Author

mustard-mh commented Feb 9, 2023

Tested, @iQQBot could you take a look? 🙏

Stable
image
Latest
image
Desktop VSCode
image

@mustard-mh mustard-mh marked this pull request as ready for review February 9, 2023 15:42
@mustard-mh mustard-mh requested a review from a team February 9, 2023 15:42
@roboquat roboquat merged commit 61c4bd1 into main Feb 9, 2023
@roboquat roboquat deleted the hw/gitpod-web-desktop branch February 9, 2023 15:44
@roboquat roboquat added deployed: IDE IDE change is running in production deployed Change is completely running in production labels Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: IDE IDE change is running in production deployed Change is completely running in production editor: code (browser) release-note size/XS team: IDE
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants