Update context dropdown element height #16208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gtsiolis
commented
Feb 3, 2023
|
/werft run with-preview=true 👍 started the job as gitpod-build-gt-update-context-dropdown-element-height.1 |
|
/werft run with-preview=true 👍 started the job as gitpod-build-gt-update-context-dropdown-element-height.2 |
|
/werft run with-preview=true 👍 started the job as gitpod-build-gt-update-context-dropdown-element-height.3 |
gtsiolis
force-pushed
the
gt/update-context-dropdown-element-height
branch
from
8014669 to
d009fa0
Compare
|
/werft run with-preview=true 👍 started the job as gitpod-build-gt-update-context-dropdown-element-height.5 |
gtsiolis
force-pushed
the
gt/update-context-dropdown-element-height
branch
from
d009fa0 to
0a38333
Compare
|
/werft run with-preview=true 👍 started the job as gitpod-build-gt-update-context-dropdown-element-height.7 |
|
Ready-For-Review 🏓 |
svenefftinge
approved these changes
Feb 16, 2023
roboquat
added
deployed: webapp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Decrease the context dropdown element min height.
See relevant discussion (internal). Cc @mbrevoort
How to test
Open the new workspace modal (
CMD+N) and notice the context dropdown element height is no fitting the content of the repository name.Release Notes
Documentation
Build Options:
Experimental feature to run the build with GitHub Actions (and not in Werft).
leeway-target=components:all
Run Leeway with
--dont-testPreview Environment Options:
If enabled this will build
install/previewIf enabled this will create the environment on GCE infra
Valid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh