Replaced loading svg icon with Loader component #16002
Conversation
|
annotations in the pull request changed, but user is not allowed to start a job |
|
started the job as gitpod-build-15896-replace-svg-with-loader-component.0 because the annotations in the pull request description changed |
|
/werft run with-preview 👍 started the job as gitpod-build-15896-replace-svg-with-loader-component-fork.0 |
|
@Ciggzy1312 Could you rebase and resolve conflicts in this one? Thanks! 🙏 |
|
/werft run with-preview 👍 started the job as gitpod-build-15896-replace-svg-with-loader-component-fork.1 |
|
/werft run with-preview 👍 started the job as gitpod-build-15896-replace-svg-with-loader-component-fork.2 |
|
@gtsiolis done, do check it and let me know |
| @@ -15,6 +15,7 @@ import CheckBox from "../components/CheckBox"; | |||
| import { ItemFieldContextMenu } from "../components/ItemsList"; | |||
| import { ContextMenuEntry } from "../components/ContextMenu"; | |||
| import Alert from "../components/Alert"; | |||
| import { SpinnerLoader } from "../components/Loader"; | |||
There was a problem hiding this comment.
issue: The SVG added seems cropped, although it renders ok. Is this using the code from #15896 (comment)? I'm adding below one more version with a square bounding box.
<svg xmlns="http://www.w3.org/2000/svg" fill="none" viewBox="0 0 16 16">
<g clip-path="url(#a)">
<path fill="#A8A29E" fill-rule="evenodd" d="M11.4284.944629C10.2681.324456 8.97283 0 7.65722 0v3c2.76138 0 4.99998 2.23858 4.99998 5 0 2.7614-2.2386 5-4.99998 5-1.38071 0-2.63071-.5596-3.53553-1.4645l-2.12132 2.1214c.93027.9302 2.07561 1.6167 3.33457 1.9986 1.25896.3819 2.59267.4474 3.883.1908 1.29036-.2567 2.49746-.8276 3.51446-1.6622 1.0169-.8346 1.8124-1.9072 2.3159-3.1226.5034-1.2155.6994-2.53636.5704-3.84564-.129-1.30927-.5788-2.56653-1.3097-3.66042-.7309-1.09389-1.7203-1.99064-2.8806-2.610811Z" clip-rule="evenodd"/>
</g>
<defs>
<clipPath id="a">
<path fill="#fff" d="M0 0h16v16H0z"/>
</clipPath>
</defs>
</svg>
roboquat
added
do-not-merge/hold
release-note
and removed
do-not-merge/release-note-label-needed
labels
|
/werft run with-preview 👍 started the job as gitpod-build-15896-replace-svg-with-loader-component-fork.3 |
|
@gtsiolis should be working this time |
|
/werft run with-clean-slate-deployment=true with-preview=true recreate-vm=true 👍 started the job as gitpod-build-15896-replace-svg-with-loader-component-fork.4 |
|
Thanks, @Ciggzy1312! Updates look good. ✨ @geropl Could you take a look or pass this to someone from the |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
Still relevant. Let's loop in @gitpod-io/engineering-webapp again in case this feel between the cracks. 🏓 |
Co-authored-by: Deepayan Mukherjee <[email protected]>
gtsiolis
force-pushed
the
15896/replace-svg-with-loader-component
branch
from
b3fc5be to
1f6e808
Compare
|
/werft run with-preview 👍 started the job as gitpod-build-15896-replace-svg-with-loader-component-fork.5 |
|
Updated the commits and the SVG icon. Removing hold as changes look trivial and this can save the Thanks, @Ciggzy1312! 🍊 /unhold |
Description
Replaced the SVG loading icon for search with a new Spinner component
Related Issue(s)
Fixes #15896
How to test
Release Notes
Documentation
Build Options:
Experimental feature to run the build with GitHub Actions (and not in Werft).
leeway-target=components:all-ci
Run Leeway with
--dont-testPreview Environment Options:
If enabled this will build
install/previewIf enabled this will create the environment on GCE infra
Valid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh