Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix] : workspace options model closes on space #15889

Merged
merged 1 commit into from
Feb 1, 2023
Merged

[fix] : workspace options model closes on space #15889

merged 1 commit into from
Feb 1, 2023

Conversation

vedant-jain03
Copy link
Contributor

@vedant-jain03 vedant-jain03 commented Jan 19, 2023 •
edited
Loading

Description

  • Initially work toggleDropDown() was called on " " space, removed that.
  • When the input is empty, space is used to toggle the dropdown else space is getting concatenated to the input.
Screencast.from.19-01-23.06.25.46.PM.IST.webm

Related Issue(s)

Fixes #15690

Release Notes

[fix] : workspace options model closes on entering space(" ")

Documentation

Build Options:

  • /werft with-github-actions
    Experimental feature to run the build with GitHub Actions (and not in Werft).
  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh

@vedant-jain03 vedant-jain03 requested a review from a team January 19, 2023 11:40
@werft-gitpod-dev-com
Copy link

annotations in the pull request changed, but user is not allowed to start a job

@werft-gitpod-dev-com
Copy link

annotations in the pull request changed, but user is not allowed to start a job

@andrew-farries
Copy link
Contributor

andrew-farries commented Jan 19, 2023 •
edited by werft-gitpod-dev-com bot
Loading

/werft run

👍 started the job as gitpod-build-issue-15690-fork.0
(with .werft/ from main)

@andrew-farries andrew-farries added the team: webapp Issue belongs to the WebApp team label Jan 19, 2023
@vedant-jain03 vedant-jain03 mentioned this pull request Jan 20, 2023
Closed
@gtsiolis
Copy link
Contributor

gtsiolis commented Jan 27, 2023 •
edited by werft-gitpod-dev-com bot
Loading

/werft run with-clean-slate-deployment=true with-preview=true recreate-vm=true

👍 started the job as gitpod-build-issue-15690-fork.1
(with .werft/ from main)

@svenefftinge
Copy link
Member

svenefftinge commented Jan 30, 2023 •
edited by werft-gitpod-dev-com bot
Loading

/werft run

👍 started the job as gitpod-build-issue-15690-fork.2
(with .werft/ from main)

@svenefftinge
Copy link
Member

svenefftinge commented Jan 30, 2023 •
edited by werft-gitpod-dev-com bot
Loading

Thank you, looks good! Can you squash the two commits into one, please? 😇

@vedant-jain03
Copy link
Contributor Author

Thank you, looks good! Can you squash the two commits into one, please? innocent

Sure!

@gtsiolis
Copy link
Contributor

gtsiolis commented Feb 1, 2023 •
edited by werft-gitpod-dev-com bot
Loading

/werft run with-clean-slate-deployment=true with-preview=true recreate-vm=true

👍 started the job as gitpod-build-issue-15690-fork.3
(with .werft/ from main)

@roboquat roboquat merged commit c656e91 into gitpod-io:main Feb 1, 2023
@vedant-jain03 vedant-jain03 deleted the issue-15690 branch February 1, 2023 09:11
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svenefftinge svenefftinge svenefftinge approved these changes

Assignees
No one assigned
Labels
community-contribution deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note size/XS team: webapp Issue belongs to the WebApp team
Projects
None yet
Milestone
No milestone
5 participants
@vedant-jain03 @andrew-farries @gtsiolis @svenefftinge @roboquat