Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[installer]: promote experimental telemetry config #15840

Merged
merged 2 commits into from
Jan 19, 2023

Conversation

mrsimonemms
Copy link
Contributor

Description

This depends upon #15773

Promote the telemetry config from experimental to the mainline

Related Issue(s)

Fixes #15836

How to test

No changes in render tests except config change

Release Notes

[installer]: promote experimental telemetry config

Documentation

Build Options:

  • /werft with-github-actions
    Experimental feature to run the build with GitHub Actions (and not in Werft).
  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh

@mrsimonemms
Copy link
Contributor Author

/hold until #15773 is merged

@mrsimonemms
Copy link
Contributor Author

/unhold

@mrsimonemms mrsimonemms force-pushed the sje/deprecate-telemetry branch from b222a0b to 3a53776 Compare January 19, 2023 08:22
@roboquat roboquat added size/M and removed size/L labels Jan 19, 2023
@mrsimonemms mrsimonemms force-pushed the sje/deprecate-telemetry branch 2 times, most recently from ed59f5f to 6b18854 Compare January 19, 2023 08:48
@mrsimonemms
Copy link
Contributor Author

/hold need to update golden files

Copy link
Contributor

@Pothulapati Pothulapati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mrsimonemms mrsimonemms force-pushed the sje/deprecate-telemetry branch from 6b18854 to 1f78acc Compare January 19, 2023 10:15
@mrsimonemms
Copy link
Contributor Author

/unhold

Copy link
Contributor

@Pothulapati Pothulapati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😬

@roboquat roboquat merged commit f366932 into main Jan 19, 2023
@roboquat roboquat deleted the sje/deprecate-telemetry branch January 19, 2023 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Promote Telemetry from experimental config
3 participants