Allow Renaming Teams #15754
Allow Renaming Teams #15754
Conversation
|
started the job as gitpod-build-se-team-rename-ui.1 because the annotations in the pull request description changed |
svenefftinge
force-pushed
the
se/team-rename-ui
branch
2 times, most recently
from
0baed74 to
e9fba89
Compare
|
Looking at this now! 👀 |
There was a problem hiding this comment.
Thanks for making this change, @svenefftinge! 🍷
UX LGTM!
Left a few non-blocking comments that can be moved to follow-up issues.
| const newName = event.target.value || ""; | ||
| setTeamName(newName); | ||
| if (newName.trim().length === 0) { | ||
| setErrorMessage("Team name must not be empty."); |
There was a problem hiding this comment.
praise: +1 for disabling the update button when users clear this input!
|
Should this be dependant on #15749? What's the relationship to that PR? They seem to share the changes |
I based the UI work on that branch. I can merge just this one as well. |
svenefftinge
force-pushed
the
se/team-rename-ui
branch
from
e9fba89 to
6936b10
Compare
|
/unhold |
| <div className="flex flex-row"> | ||
| <button | ||
| className="primary" | ||
| disabled={team?.name === teamName || !!errorMessage} |
There was a problem hiding this comment.
nit: currently, the user is able to change the team name to the same name just with whitespaces around it.
| disabled={team?.name === teamName || !!errorMessage} | |
| disabled={team?.name === teamName.trim() || !!errorMessage} |
roboquat
added
deployed: webapp
Allow updating the team's name
fixes #5067
How to test
rename team name
Release Notes
Documentation
Werft options:
If enabled this will build
install/previewValid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh