[server] Wait for image build logs in preparing state #15586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
started the job as gitpod-build-wv-image-build-retry-preparing.1 because the annotations in the pull request description changed |
github-actions
bot
added
team: webapp
WVerlaek
commented
Jan 5, 2023
Comment on lines
+1
to
+7
| #!/bin/bash | ||
| # Copyright (c) 2022 Gitpod GmbH. All rights reserved. | ||
| # Licensed under the GNU Affero General Public License (AGPL). | ||
| # See License.AGPL.txt in the project root for license information. | ||
|
|
||
| set -Eeuo pipefail | ||
| source /workspace/gitpod/scripts/ws-deploy.sh deployment dashboard |
There was a problem hiding this comment.
added this script as well which was useful in iterating on the dashboard component in a preview environment, the script is also present in components/server already
AlexTugarev
approved these changes
Jan 6, 2023
|
/hold |
WVerlaek
force-pushed
the
wv/image-build-retry-preparing
branch
from
dba32e3 to
4dee440
Compare
roboquat
added
deployed: webapp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes image build logs from showing up in the dashboard if the build is delayed.
When a workspace's image build is delayed (due to e.g. waiting for a node to scale up), the workspace instance stays in a
preparingstate, it only moves tobuildingonce the build is actually running. Previously, the logic would stop retrying for build logs if it's not in abuildingstate, this PR changes it to also wait for build logs while in apreparingstateRelated Issue(s)
Fixes #14862
How to test
In a preview environment:
https://<your-preview-env>.preview.gitpod-dev.com/#imagebuild/github.com/gitpod-io/gitpodRelease Notes
Documentation
Werft options:
If enabled this will build
install/previewValid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh