Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: repository template for JetBrains IDEs #15503

Merged
merged 1 commit into from
Dec 27, 2022
Merged

Conversation

Siddhant-K-code
Copy link
Member

@Siddhant-K-code Siddhant-K-code commented Dec 24, 2022

Signed-off-by: Siddhant Khare [email protected]

Description

Example Repo. URL Changes with new selection. Would not change if user has changed the text field.

Demo Video:

Screen.Recording.2022-12-27.at.10.50.04.PM.mov

Related Issue(s)

Currently, It only shows https://github.com/gitpod-samples/spring-petclinic doesn't matter which IDE you select (IntelliJ/PyCharm/WebStorm/etc.)

How to test

  1. Ensure you have the Gateway installed from JetBrains Toolbox App and have it up-to-date.
  2. Download the plugin build related to this branch in Dev Versions, and install it on the Gateway.
  3. Create a new workspace from the Gateway (it's ok to use the pre-selected IDE and Repository) and confirm if JetBrains Client can connect to it.

Release Notes

Customised example repositories on the basis of selected IDE options 

Werft options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-clean-slate-deployment
  • /werft with-large-vm
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh

@werft-gitpod-dev-com

This comment was marked as resolved.

@werft-gitpod-dev-com

This comment was marked as resolved.

@felladrin
Copy link
Contributor

That looks great!

We can add one check over these changes: avoid replacing the repository URL if the user has already changed it.
For example, I open the Gateway, go to the Gitpod plugin page, and change the URL from https://github.com/gitpod-samples/spring-petclinic to https://github.com/gitpod-io/gitpod, then I decide to use GoLand instead of IDEA. In this case, I'd want to keep https://github.com/gitpod-io/gitpod in the repository field.

@roboquat roboquat added size/M and removed size/S labels Dec 27, 2022
@werft-gitpod-dev-com

This comment was marked as resolved.

@werft-gitpod-dev-com

This comment was marked as resolved.

@Siddhant-K-code Siddhant-K-code marked this pull request as ready for review December 27, 2022 17:15
@Siddhant-K-code Siddhant-K-code requested a review from a team December 27, 2022 17:15
@Siddhant-K-code Siddhant-K-code changed the title [Draft] chore: repository template for JetBrains IDEs chore: repository template for JetBrains IDEs Dec 27, 2022
Copy link
Contributor

@felladrin felladrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this feature! 💯

@roboquat roboquat merged commit c4a1d0c into main Dec 27, 2022
@roboquat roboquat deleted the checkout/template-url branch December 27, 2022 18:03
@roboquat roboquat added deployed: IDE IDE change is running in production deployed Change is completely running in production labels Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: IDE IDE change is running in production deployed Change is completely running in production release-note size/M team: IDE
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants