[server] Allow options on ws start (1/2) #15388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
introduces IDE and workspace class arguments on WS Start
github-actions
bot
added
team: IDE
team: webapp
|
started the job as gitpod-build-se-start-with-options.1 because the annotations in the pull request description changed |
|
/hold |
easyCZ
approved these changes
Dec 16, 2022
geropl
reviewed
Dec 16, 2022
|
Code LGTM as well; would be nice if we could do a little bit of testing (starting at least one workspace) as well. 🧘 |
akosyakov
approved these changes
Dec 16, 2022
akosyakov
reviewed
Dec 16, 2022
| return this.doResolveWorkspaceConfig( | ||
| workspace, | ||
| userSelectedIdeSettings || user.additionalData?.ideSettings, | ||
| ); | ||
| } | ||
|
|
||
| const deprecated = await this.resolveDeprecated(workspace, user); |
There was a problem hiding this comment.
(fyi) this branch is not used, and it is going away next week
svenefftinge
changed the title
|
/unhold |
roboquat
added
deployed: webapp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Introduces optional IDE and workspace class arguments on workspace start.
This is a precursor for #15287
Related Issue(s)
Fixes #
How to test
Release Notes
Documentation
Werft options:
If enabled this will build
install/previewValid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh