Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update beta notice for the JetBrains integration #15371

Merged
merged 1 commit into from
Dec 16, 2022
Merged

Update beta notice for the JetBrains integration #15371

merged 1 commit into from
Dec 16, 2022

Conversation

gtsiolis
Copy link
Contributor

@gtsiolis gtsiolis commented Dec 15, 2022 •
edited
Loading

Description

This will update the beta notice for the JetBrains integration, making the beta label more prominent.

See relevant discussion (internal). Cc @akosyakov @loujaybee @easyCZ

Benefits:

  • Making beta notice more prominent.
  • Better UX (colors, structure, etc)
  • Linking to the Gitpod releases page.
  • Reusing the PillLabel component.
  • Using similar pattern as in Update beta label on teams, projects, and usage #15017.
    • X feature is in BETA · Send Feedback
    • Y integration is in BETA · Send Feedback
BEFORE AFTER
beta-before beta-after

How to test

Go to user /preferences and notice the new beta notice for the JetBrains integration.

Release Notes

Update beta notice for the JetBrains integration

Werft options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh

@gtsiolis gtsiolis requested a review from a team December 15, 2022 14:29
@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-gt-update-jetbrains-integration-beta-notice.2 because the annotations in the pull request description changed
(with .werft/ from main)

@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Dec 15, 2022
loujaybee
loujaybee approved these changes Dec 15, 2022
View reviewed changes
Copy link
Member

@loujaybee loujaybee left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Praise: Nice! Very clean. Much prefer the wording for "JetBrains integration".

@roboquat roboquat merged commit 5fc5f08 into main Dec 16, 2022
@roboquat roboquat deleted the gt/update-jetbrains-integration-beta-notice branch December 16, 2022 08:14
@gtsiolis
Copy link
Contributor Author

gtsiolis commented Dec 16, 2022 •
edited by werft-gitpod-dev-com bot
Loading

Thanks, @loujaybee @svenefftinge! 🏀

@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Dec 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loujaybee loujaybee loujaybee approved these changes

@svenefftinge svenefftinge svenefftinge approved these changes

Assignees
No one assigned
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note size/S team: webapp Issue belongs to the WebApp team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gtsiolis @svenefftinge @loujaybee @roboquat