Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace prebuild duration message emoji #15364

Merged
merged 1 commit into from
Dec 15, 2022

Conversation

gtsiolis
Copy link
Contributor

@gtsiolis gtsiolis commented Dec 15, 2022

Description

Following up from a relevant discussions[1][2] (internal), this will replace the prebuild duration message emoji from 🎉 to ⏱️ to help disassociate the prebuild status (SUCCESS, FAIL) for from the prebuild task status.

// BEFORE 
🎉 Well done on saving 7 minutes

// AFTER
⏱️ Well done on saving 7 minutes

See parallel fix https://github.com/gitpod-io/website/pull/3164. 🏓

Follow-up improvements could include:

How to test

Run a prebuild with a task that fails, causing a prebuild to fail, but notice the prebuilds duration message is using a different emoji that does not imply a successful prebuild.

Release Notes

Replace prebuild duration message emoji

Werft options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh

@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-gt-replace-prebuild-duration-message-emoji.1 because the annotations in the pull request description changed
(with .werft/ from main)

@gtsiolis gtsiolis mentioned this pull request Dec 15, 2022
4 tasks
@roboquat roboquat merged commit f41eb43 into main Dec 15, 2022
@roboquat roboquat deleted the gt/replace-prebuild-duration-message-emoji branch December 15, 2022 14:56
@gtsiolis
Copy link
Contributor Author

gtsiolis commented Dec 15, 2022

Thanks for taking a look, @jeanp413! ☀️

@roboquat roboquat added deployed: IDE IDE change is running in production deployed Change is completely running in production labels Dec 16, 2022
@jankeromnes
Copy link
Contributor

jankeromnes commented Dec 27, 2022

Hey, cool new emojis! 😁 ✨

But FYI, I noticed a small spacing issue that seems new: #15508

Screenshot 2022-12-27 at 10 35 45

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: IDE IDE change is running in production deployed Change is completely running in production release-note size/XS team: IDE
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants