Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding team.slug to findTeams query #15338

Merged
merged 2 commits into from
Dec 20, 2022
Merged

adding team.slug to findTeams query #15338

merged 2 commits into from
Dec 20, 2022

Conversation

selfcontained
Copy link
Contributor

@selfcontained selfcontained commented Dec 14, 2022

Description

Adjusting the findTeams query to use the searchTerm for either team.name or team.slug.

Searching by team-slug
image

Related Issue(s)

Fixes #12982

How to test

Preview Env: https://bmh-searche1a0adc542.preview.gitpod-dev.com/

  • Create a team named something like Test Team
  • Go to Admin/Teams and search for the team by it's slug, test-team
  • The team should display in the results

Release Notes

NONE

Documentation

Werft options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh

@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-bmh-search-by-team-slug.2 because the annotations in the pull request description changed
(with .werft/ from main)

@selfcontained selfcontained marked this pull request as ready for review December 15, 2022 23:11
@selfcontained selfcontained requested a review from a team December 15, 2022 23:11
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Dec 15, 2022
@selfcontained
Copy link
Contributor Author

/hold for feedback

Copy link
Member

@geropl geropl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, tested and tests are 🟢 : ✔️

@selfcontained
Copy link
Contributor Author

selfcontained commented Dec 16, 2022

/werft run

👍 started the job as gitpod-build-bmh-search-by-team-slug.4
(with .werft/ from main)

@selfcontained
Copy link
Contributor Author

/unhold

@aledbf
Copy link
Member

aledbf commented Dec 19, 2022

/hold

(build is failing)

@aledbf
Copy link
Member

aledbf commented Dec 19, 2022

/werft run

👍 started the job as gitpod-build-bmh-search-by-team-slug.6
(with .werft/ from main)

@selfcontained selfcontained force-pushed the bmh/search-by-team-slug branch from 12bf873 to 8ae44cf Compare December 20, 2022 15:55
@easyCZ
Copy link
Member

easyCZ commented Dec 20, 2022

/werft run

👍 started the job as gitpod-build-bmh-search-by-team-slug.8
(with .werft/ from main)

@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-bmh-search-by-team-slug.9 because the annotations in the pull request description changed
(with .werft/ from main)

@selfcontained
Copy link
Contributor Author

/unhold

@roboquat roboquat merged commit a33857e into main Dec 20, 2022
@roboquat roboquat deleted the bmh/search-by-team-slug branch December 20, 2022 18:39
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Dec 21, 2022
@atduarte
Copy link
Contributor

FYI @selfcontained removed release notes as the admin panel is now only being developed for us internally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note-none size/S team: webapp Issue belongs to the WebApp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Admin dashboard - team list cannot be searched by team slug
6 participants