Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refresh-credential] rotate the AWS ECR credential by schedule #15313

Merged
merged 14 commits into from
Dec 15, 2022
Merged
Prev Previous commit
Next Next commit
Check secret key credentials
Signed-off-by: JenTing Hsiao <hsiaoairplane@gmail.com>
  • Loading branch information
jenting committed Dec 15, 2022
commit c09d2f9a4fa27a3d4dec13935507db342bb4c90c
4 changes: 2 additions & 2 deletions install/installer/pkg/config/v1/validation.go
Original file line number Diff line number Diff line change
@@ -150,9 +150,9 @@ func (v version) ClusterValidation(rcfg interface{}) cluster.ValidationChecks {
secretName := cfg.ContainerRegistry.External.Certificate.Name
res = append(res, cluster.CheckSecret(secretName, cluster.CheckSecretRequiredData(".dockerconfigjson")))

if cfg.ContainerRegistry.External != nil {
if cfg.ContainerRegistry.External.Credentials != nil {
credSecretName := cfg.ContainerRegistry.External.Credentials.Name
res = append(res, cluster.CheckSecret(credSecretName, cluster.CheckSecretRequiredData("accessKeyId", "secretAccessKey")))
res = append(res, cluster.CheckSecret(credSecretName, cluster.CheckSecretRequiredData("credentials")))
}
}