Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[installer]: add required bucket name to mirror kots command #15296

Merged
merged 1 commit into from
Dec 12, 2022

Conversation

mrsimonemms
Copy link
Contributor

@mrsimonemms mrsimonemms commented Dec 12, 2022

Description

The new required bucket name from #14970 is now implemented in the mirror kots command, which is used by Werft to generate the list of images for KOTS air-gapped support.

Related Issue(s)

Fixes #15294

How to test

Use /werft run publish-to-kots to make Werft publish the KOTS release (I've done this already)

Release Notes

[installer]: add required bucket name to mirror kots command

Documentation

Werft options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh

@mrsimonemms
Copy link
Contributor Author

mrsimonemms commented Dec 12, 2022

/werft run publish-to-kots

👍 started the job as gitpod-build-mrsimonemms-publish-kots-field-15294.1
(with .werft/ from main)

@mrsimonemms mrsimonemms marked this pull request as ready for review December 12, 2022 08:54
@mrsimonemms mrsimonemms requested a review from a team December 12, 2022 08:54
Copy link
Contributor

@Pothulapati Pothulapati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the errors in build failures, Seems to be like the right fix! ✅

@roboquat roboquat merged commit 5b27ce7 into main Dec 12, 2022
@roboquat roboquat deleted the mrsimonemms/publish-kots-field-15294 branch December 12, 2022 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Publish kots: Field 'Config.ObjectStorage.S3.BucketName' is required
3 participants