Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dashboard] allow setting ws class for prebuilds #15288

Merged
merged 1 commit into from
Dec 12, 2022
Merged

[dashboard] allow setting ws class for prebuilds #15288

merged 1 commit into from
Dec 12, 2022

Conversation

svenefftinge
Copy link
Member

@svenefftinge svenefftinge commented Dec 11, 2022 •
edited
Loading

Description

Allow selecting the workspace class for prebuilds

Related Issue(s)

Fixes #14811

How to test

  • join this team
  • start a workspace on this branch
  • Verify that the prebuild.txt contains information about using a small workspace class
  • Verify that running gp info reveals that the workspace is running in a default workspace class

Screenshot 2022-12-12 at 07 40 34

Release Notes

Allow setting workspace class for prebuilds

Documentation

Werft options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh

@svenefftinge svenefftinge requested a review from a team December 11, 2022 15:35
@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-sefftinge-project-settings-allow-14811.1 because the annotations in the pull request description changed
(with .werft/ from main)

@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Dec 11, 2022
@svenefftinge
Copy link
Member Author

svenefftinge commented Dec 11, 2022 •
edited by werft-gitpod-dev-com bot
Loading

/werft run with-clean-slate-deployment

👍 started the job as gitpod-build-sefftinge-project-settings-allow-14811.2
(with .werft/ from main)

@svenefftinge
Copy link
Member Author

svenefftinge commented Dec 12, 2022 •
edited by werft-gitpod-dev-com bot
Loading

/werft run with-clean-slate-deployment

👍 started the job as gitpod-build-sefftinge-project-settings-allow-14811.3
(with .werft/ from main)

@roboquat roboquat merged commit 5e0c93c into main Dec 12, 2022
@roboquat roboquat deleted the sefftinge/project-settings-allow-14811 branch December 12, 2022 07:39
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@easyCZ easyCZ easyCZ approved these changes

Assignees
No one assigned
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note size/M team: webapp Issue belongs to the WebApp team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[project settings] Allow setting workspace class for prebuilds independently
3 participants
@svenefftinge @easyCZ @roboquat