Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ws-daemon: Do not land workspaces on the node with broken ws-daemon #15262

Merged
merged 2 commits into from
Dec 12, 2022
Merged

ws-daemon: Do not land workspaces on the node with broken ws-daemon #15262

merged 2 commits into from
Dec 12, 2022

Conversation

utam0k
Copy link
Contributor

@utam0k utam0k commented Dec 9, 2022 •
edited by atduarte
Loading

Description

Follow up #15053

Related Issue(s)

Fixes #

How to test

https://loom.com/share/6b0935660168482d88c92680293b77e9

  • Node label, gitpod.io/ws-daemon_ready_ns_default disappears when deleting a ws-daemon container and turn on when registry-facade comes back
  • Node label, gitpod.io/ws-daemon_ready_ns_default disappears when deleting a ws-daemon pod and turns on when rws-daemon come back

Release Notes

Fix bug where workspaces sporadically landed on an unhealthy node

Documentation

Werft options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-integration-tests=workspace
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh

@utam0k utam0k requested a review from a team December 9, 2022 07:37
@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-to-ws-daemon-label.5 because the annotations in the pull request description changed
(with .werft/ from main)

@roboquat roboquat added the size/S label Dec 9, 2022
@github-actions github-actions bot added the team: workspace Issue belongs to the Workspace team label Dec 9, 2022
@utam0k utam0k changed the title ws-daemon: Ensure that node-labeler always monitors the ws-daemon container ws-daemon: Do not land workspaces on the node with broken ws-daemon Dec 9, 2022
sagor999
sagor999 approved these changes Dec 9, 2022
View reviewed changes
Copy link
Contributor

@sagor999 sagor999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold for @jenting to resolve his comment or pursue further if I am wrong in my assessment.

@sagor999
Copy link
Contributor

sagor999 commented Dec 9, 2022 •
edited by werft-gitpod-dev-com bot
Loading

/werft run

👍 started the job as gitpod-build-to-ws-daemon-label.6
(with .werft/ from main)

@utam0k utam0k self-assigned this Dec 12, 2022
@utam0k
Copy link
Contributor Author

utam0k commented Dec 12, 2022

I'm fixing the conflicts...

@utam0k utam0k force-pushed the to/ws-daemon-label branch from 96090bf to abaa45c Compare December 12, 2022 01:30
jenting
jenting approved these changes Dec 12, 2022
View reviewed changes
Copy link
Contributor

@jenting jenting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to unhold it once you fix the CI.

@utam0k utam0k force-pushed the to/ws-daemon-label branch from abaa45c to b94e7f3 Compare December 12, 2022 06:20
@utam0k
Copy link
Contributor Author

utam0k commented Dec 12, 2022

/unhold

@roboquat roboquat merged commit ea1090b into main Dec 12, 2022
@roboquat roboquat deleted the to/ws-daemon-label branch December 12, 2022 07:00
@roboquat roboquat added deployed: workspace Workspace team change is running in production deployed Change is completely running in production labels Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kylos101 kylos101 kylos101 left review comments

@jenting jenting jenting approved these changes

@sagor999 sagor999 sagor999 approved these changes

Assignees

@utam0k utam0k

Labels
deployed: workspace Workspace team change is running in production deployed Change is completely running in production release-note size/S team: workspace Issue belongs to the Workspace team
Projects
No open projects
🌌 Workspace Team
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@utam0k @sagor999 @kylos101 @jenting @roboquat