Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[content-service] Prevent permission denied during content init #15216

Merged
merged 1 commit into from
Dec 7, 2022

Conversation

Furisto
Copy link
Member

@Furisto Furisto commented Dec 7, 2022

Description

For details see #11183

Related Issue(s)

Fixes #11183

How to test

  1. Run these tests 👇
  • Open a workspace. In the terminal execute:
touch basic
sudo touch root-file
touch executable-file
chmod +x executable-file
touch suid-file
chmod 2555 suid-file
mkdir suid-directory
chmod g+s suid-directory
  • Check the output of ls -lat, should be similar to
drwxr-x--- 8 gitpod gitpod 4096 Apr 28 17:31 .
-r-xr-sr-x 1 gitpod gitpod    0 Apr 28 17:31 suid-file
drwxr-sr-x 2 gitpod gitpod    6 Apr 28 17:31 suid-directory
-rwxr-xr-x 1 gitpod gitpod    0 Apr 28 17:30 executable-file
-rw-r--r-- 1 root   root      0 Apr 28 17:30 root-file
-rw-r--r-- 1 gitpod gitpod    0 Apr 28 17:30 basic
  • Stop and open the workspace
  • Open a terminal and run ls -lat
  • Compare the outputs
  1. Assert the steps to recreate here do not fail

  2. Open this repository: https://github.com/Furisto/gitpod-repro/tree/content-init-11183

    • Wait for the workspace and Supertokens to be started
    • Stop the workspace and wait for it to be stopped
    • Open and start workspace -> There should be no error

Release Notes

Fix issue that prevented a few stopped workspaces from being restarted

Werft options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-integration-tests=workspace
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh

@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-fo-content-init-fix.6 because the annotations in the pull request description changed
(with .werft/ from main)

@Furisto Furisto self-assigned this Dec 7, 2022
@Furisto Furisto added team: workspace Issue belongs to the Workspace team and removed size/XS labels Dec 7, 2022
@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-fo-content-init-fix.7 because the annotations in the pull request description changed
(with .werft/ from main)

@Furisto
Copy link
Member Author

Furisto commented Dec 7, 2022

/werft run with-preview=true with-integration-tests=true with-large-vm=true

👍 started the job as gitpod-build-fo-content-init-fix.8
(with .werft/ from main)

@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-fo-content-init-fix.9 because the annotations in the pull request description changed
(with .werft/ from main)

@Furisto
Copy link
Member Author

Furisto commented Dec 7, 2022

/werft run with-preview=true with-integration-tests=true with-large-vm=true

👍 started the job as gitpod-build-fo-content-init-fix.10
(with .werft/ from main)

@Furisto Furisto marked this pull request as ready for review December 7, 2022 18:57
@Furisto Furisto requested a review from a team December 7, 2022 18:57
@roboquat roboquat merged commit 3514a5d into main Dec 7, 2022
@roboquat roboquat deleted the fo/content-init-fix branch December 7, 2022 23:10
@roboquat roboquat added deployed: workspace Workspace team change is running in production deployed Change is completely running in production labels Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: workspace Workspace team change is running in production deployed Change is completely running in production release-note size/XS team: workspace Issue belongs to the Workspace team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[content-service] cannot restart stopped workspace
3 participants