Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update new team page layout #15016

Merged
merged 1 commit into from
Nov 29, 2022
Merged

Update new team page layout #15016

merged 1 commit into from
Nov 29, 2022

Conversation

gtsiolis
Copy link
Contributor

@gtsiolis gtsiolis commented Nov 28, 2022 •
edited
Loading

Description

Minor style changes to the new team page layout, following some of the initial design specs in #4951.

This will also:

  1. Update the page subtitle to remove inaccurate information like grouping workspaces.
  2. Experiment with a new form heading to help guide users.
BEFORE AFTER
Screenshot 2022-11-28 at 9 21 55 PM (2) Screenshot 2022-11-28 at 9 20 49 PM (2)

Related Issue(s)

Fixes #4951

How to test

See the new team page layout.

Release Notes

Update new team page layout

Werft options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh

@gtsiolis gtsiolis requested a review from a team November 28, 2022 19:25
@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-gt-update-new-team-page.4 because the annotations in the pull request description changed
(with .werft/ from main)

@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Nov 28, 2022
jankeromnes
jankeromnes approved these changes Nov 29, 2022
View reviewed changes
Copy link
Contributor

@jankeromnes jankeromnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks! These changes make sense to me ✨

I'm just adding a hold for one optional suggestion and one question. 😇 Please feel free to address these in your own time, and then merge this PR. 🛹

/hold

components/dashboard/src/teams/NewTeam.tsx Outdated Show resolved Hide resolved
components/dashboard/src/teams/NewTeam.tsx Show resolved Hide resolved
@gtsiolis gtsiolis force-pushed the gt/update-new-team-page branch 2 times, most recently from fd7bbdd to 92d975e Compare November 29, 2022 09:28
@gtsiolis @jankeromnes
Update new team page layout
a57130b 
Co-authored-by: Jan Keromnes <[email protected]>
@gtsiolis gtsiolis force-pushed the gt/update-new-team-page branch from 92d975e to a57130b Compare November 29, 2022 09:32
@gtsiolis
Copy link
Contributor Author

Thanks for taking a look, @jankeromnes!

/unhold

@roboquat roboquat merged commit 68bcb48 into main Nov 29, 2022
@roboquat roboquat deleted the gt/update-new-team-page branch November 29, 2022 09:46
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jankeromnes jankeromnes jankeromnes approved these changes

Assignees
No one assigned
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note size/S team: webapp Issue belongs to the WebApp team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update team creation designs
3 participants
@gtsiolis @jankeromnes @roboquat