Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Truncate branch name on prebuilds page #14853

Merged
merged 1 commit into from
Nov 22, 2022
Merged

Truncate branch name on prebuilds page #14853

merged 1 commit into from
Nov 22, 2022

Conversation

gtsiolis
Copy link
Contributor

Description

This will truncate the branch name on the prebuilds page.

How to test

  1. Create a team and a project
  2. Trigger a prebuild with a branch using a long branch name
  3. Go to the prebuilds page and notice the branch name truncating

Screenshots

BEFORE AFTER
prebuilds-list-before prebuilds-list-after

Release Notes

Truncate branch name on prebuilds page

Werft options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh

@gtsiolis gtsiolis requested a review from a team November 22, 2022 12:46
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Nov 22, 2022
@roboquat roboquat merged commit 162215b into main Nov 22, 2022
@roboquat roboquat deleted the gt/truncate-branch-on-prebuilds branch November 22, 2022 13:03
@gtsiolis
Copy link
Contributor Author

gtsiolis commented Nov 22, 2022 •
edited by werft-gitpod-dev-com bot
Loading

Thanks for taking a look, @andrew-farries! 🍵

@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrew-farries andrew-farries andrew-farries approved these changes

Assignees
No one assigned
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note size/S team: webapp Issue belongs to the WebApp team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gtsiolis @andrew-farries @roboquat