Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert removing the workspace download feature #14828

Merged
merged 1 commit into from
Nov 21, 2022
Merged

Revert removing the workspace download feature #14828

merged 1 commit into from
Nov 21, 2022

Conversation

gtsiolis
Copy link
Contributor

@gtsiolis gtsiolis commented Nov 21, 2022 •
edited
Loading

Description

This will restore the removed workspace download functionality.

See relevant discussion (internal). Cc @kylos101 @atduarte @jldec

How to test

  1. Open a new workspace
  2. Stop the workspace
  3. Go to the workspaces list
  4. Notice the download menu in the workspace more actions dropdown exists
  5. Download the stopped workspace

Release Notes

Revert removing the workspace download feature

Documentation

Werft options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh

@gtsiolis gtsiolis requested a review from a team November 21, 2022 16:57
@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-gt-revert-removing-download-feature.1 because the annotations in the pull request description changed
(with .werft/ from main)

@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Nov 21, 2022
@gtsiolis
Copy link
Contributor Author

gtsiolis commented Nov 21, 2022 •
edited by werft-gitpod-dev-com bot
Loading

/werft run with-preview

👍 started the job as gitpod-build-gt-revert-removing-download-feature.2
(with .werft/ from main)

@gtsiolis
Copy link
Contributor Author

gtsiolis commented Nov 21, 2022 •
edited by werft-gitpod-dev-com bot
Loading

Ready-For-Review 🏓

@roboquat roboquat merged commit 4c338c6 into main Nov 21, 2022
@roboquat roboquat deleted the gt/revert-removing-download-feature branch November 21, 2022 20:26
@gtsiolis
Copy link
Contributor Author

gtsiolis commented Nov 21, 2022 •
edited by werft-gitpod-dev-com bot
Loading

Thanks, @easyCZ! 🌮 🌮

@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Nov 22, 2022
@gtsiolis gtsiolis mentioned this pull request Nov 28, 2022
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@easyCZ easyCZ easyCZ approved these changes

Assignees
No one assigned
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note size/S team: webapp Issue belongs to the WebApp team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gtsiolis @easyCZ @roboquat