Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update usage period date format #14827

Merged
merged 1 commit into from
Nov 21, 2022
Merged

Conversation

gtsiolis
Copy link
Contributor

@gtsiolis gtsiolis commented Nov 21, 2022

Description

Following up from #14705, this will 🅰️ update the usage period date format, moving away from the fixed month-based named period, and 🅱️ use a more appropriate dash punctuation mark (En Dash) for separating the date range.

How to test

  1. Enable UBP flag. //TODO: We definitely need a link to describe how to enable a feature flag.
  2. Go to /billing
  3. Notice the difference in current period date format

Screenshots

BEFORE AFTER
billing-before billing-after

Release Notes

Update usage period date format

Documentation

Werft options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh

@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-gt-update-usage-period-date-format.1 because the annotations in the pull request description changed
(with .werft/ from main)

@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Nov 21, 2022
@gtsiolis
Copy link
Contributor Author

Cc @jankeromnes @easyCZ because #14705
Cc @jldec because we briefly discussed this in a recent sync meeting

@gtsiolis
Copy link
Contributor Author

gtsiolis commented Nov 21, 2022

Ready-For-Review 🏓

@roboquat roboquat merged commit 21adcfd into main Nov 21, 2022
@roboquat roboquat deleted the gt/update-usage-period-date-format branch November 21, 2022 20:25
@gtsiolis
Copy link
Contributor Author

gtsiolis commented Nov 21, 2022

Thanks for taking a look, @easyCZ! 🥯

@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note size/XS team: webapp Issue belongs to the WebApp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants