Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[installer]: validate the node labels by kind in config #14691

Merged
merged 1 commit into from
Nov 15, 2022

Conversation

mrsimonemms
Copy link
Contributor

@mrsimonemms mrsimonemms commented Nov 15, 2022

Description

The Installer's validate cluster command checked the node labels as if the kind in the config file was always Full.

This removes this assumption and creates separate target affinities based upon the kind.

This PR is bigger than I'd hoped, but that's because I needed to move the checkAffinityLabels into the config/v1 package due to circular dependencies.

Related Issue(s)

Fixes #14598

How to test

  • go run . config init
  • Set the kind in gitpod.config.yaml to either Full, Meta or Workspace
  • Run go run . validate cluster
  • The affinity labels check should be as below...

Full

{
  "name": "affinity labels",
  "description": "all required affinity node labels [gitpod.io/workload_meta gitpod.io/workload_ide gitpod.io/workload_workspace_services gitpod.io/workload_workspace_regular gitpod.io/workload_workspace_headless] are present in the cluster",
  "status": "OK"
}

Meta

{
  "name": "affinity labels",
  "description": "all required affinity node labels [gitpod.io/workload_meta gitpod.io/workload_ide] are present in the cluster",
  "status": "OK"
}

Workspace

{
  "name": "affinity labels",
  "description": "all required affinity node labels [gitpod.io/workload_workspace_services gitpod.io/workload_workspace_regular gitpod.io/workload_workspace_headless] are present in the cluster",
  "status": "OK"
}

Release Notes

[installer]: validate the node labels by kind in config

Documentation

Werft options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh

Copy link
Contributor

@Pothulapati Pothulapati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected! :shipit:

@roboquat roboquat merged commit 151f8d5 into main Nov 15, 2022
@roboquat roboquat deleted the sje/installer-kind-cluster-validation branch November 15, 2022 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Installer]: when kind: Meta, workspace node label errors still show
3 participants