[installer]: validate the node labels by kind in config #14691
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The Installer's
validate cluster
command checked the node labels as if thekind
in the config file was alwaysFull
.This removes this assumption and creates separate target affinities based upon the
kind
.This PR is bigger than I'd hoped, but that's because I needed to move the
checkAffinityLabels
into theconfig/v1
package due to circular dependencies.Related Issue(s)
Fixes #14598
How to test
go run . config init
kind
ingitpod.config.yaml
to eitherFull
,Meta
orWorkspace
go run . validate cluster
affinity labels
check should be as below...Full
Meta
Workspace
Release Notes
Documentation
Werft options:
If enabled this will build
install/preview
Valid options are
all
,workspace
,webapp
,ide
,jetbrains
,vscode
,ssh