-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JetBrains] Ensure prebuilt workspaces using Maven Wrapper are properly initialized in IntelliJ IDEA #14656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
felladrin
commented
Nov 14, 2022
components/ide/jetbrains/backend-plugin/src/main/resources/META-INF/plugin.xml
Show resolved
Hide resolved
This comment was marked as resolved.
This comment was marked as resolved.
felladrin
force-pushed
the
ak/init_maven
branch
from
November 14, 2022 20:05
ecb13e3
to
b380926
Compare
This comment was marked as resolved.
This comment was marked as resolved.
felladrin
changed the title
[JetBrains] Force the initialization of Maven projects
[JetBrains] Ensure projects using Maven Wrapper are always initialized
Nov 15, 2022
This comment was marked as resolved.
This comment was marked as resolved.
felladrin
requested review from
akosyakov
and removed request for
andreafalzetti
November 15, 2022 09:41
felladrin
changed the title
[JetBrains] Ensure projects using Maven Wrapper are always initialized
[JetBrains] Ensure prebuilt workspaces using Maven Wrapper are properly initialized in IntelliJ IDEA
Nov 15, 2022
This comment was marked as resolved.
This comment was marked as resolved.
to work around initialization after warmup in prebuilds Co-authored-by: Victor Nogueira <[email protected]>
felladrin
force-pushed
the
ak/init_maven
branch
from
November 17, 2022 08:03
b380926
to
7c7f8c1
Compare
This comment was marked as resolved.
This comment was marked as resolved.
akosyakov
approved these changes
Nov 17, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we tried together, and it seems to improve importing after prebuilds
roboquat
added
deployed: IDE
IDE change is running in production
deployed
Change is completely running in production
labels
Nov 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
deployed: IDE
IDE change is running in production
deployed
Change is completely running in production
editor: jetbrains
release-note
size/M
team: IDE
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, repositories using Maven Wrapper may fail to be loaded as a Maven Project if they are prebuilt with some specific file combination and then opened in JetBrains IntelliJ IDEA in Gitpod.
In summary:
.xml
file inside.idea
folder, it won't load the Maven Projects correctly.You can see this behaviour by selecting Stable IntelliJ IDEA and starting a workspace from this URL.
.idea
folder.You can see this behaviour by selecting Stable IntelliJ IDEA and starting a workspace from this URL.
.idea/misc.xml
,.idea/modules.xml
, and.idea/spring-petclinic.iml
.You can see this behaviour by selecting Stable IntelliJ IDEA and starting a workspace from this URL.
This PR reinitializes the Maven Project Manager after the IDE is loaded, so it overcomes the issue of Maven Project not being detected when JetBrains Client connects.
References:
Related Issue(s)
How to test
(Optional) Extra tests you can run on this Preview Environment
Release Notes
Post-merge actions
.idea/modules.xml
and.idea/spring-petclinic.iml
from https://github.com/Gitpod-Samples/spring-petclinicfelladrin/prebuilt-maven-project-without-idea-folder
andfelladrin/prebuilt-maven-project-without-iml-file
from https://github.com/Gitpod-Samples/spring-petclinicWerft options: