[Gitpod CLI] Display helper for unknown subcommands #14630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
started the job as gitpod-build-afalz-gp-cli-unknwon-subcmds.1 because the annotations in the pull request description changed |
andreafalzetti
force-pushed
the
afalz/gp-cli-unknwon-subcmds
branch
from
7fccb8e to
7996257
Compare
roboquat
added
deployed: IDE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Running unknown subcommands of
portsandtaskswould not return any output which is an odd and confusing behaviour.The reason being that the helper is only triggered when there are no args. Unknown subcommands that don't match registered subcommands are considered arguments and the helper is only displayed when there are no arguments.
Related Issue(s)
Fixes #
How to test
gp ports XXXobserve how the helper and an error are displayedgp ports listto make sure subcommands continue to workgp tasks XXXobserve how the helper and an error are displayedgp tasks listto make sure subcommands continue to workRelease Notes
Documentation
Werft options:
If enabled this will build
install/previewValid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh