Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[server] Fix UBP free tier edge case + tests #14557

Merged
merged 1 commit into from
Nov 9, 2022
Merged

Conversation

geropl
Copy link
Member

@geropl geropl commented Nov 9, 2022

Description

We missed a gap when changing UBP semantics during earlier changes. This now ensures that you definitely are subject to "UBP free tier" if you don't:

  • have an active personal subscription
  • have an active Team Seat/Membership

Related Issue(s)

Fixes #14552

How to test

Run unit tests in a workspace:

  • leeway build components/gitpod-db:dbtest-init
  • (cd components/server && yarn db-test)

Release Notes

fix rollout behavior of Usage-Based Pricing

Documentation

Werft options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh

@geropl geropl marked this pull request as ready for review November 9, 2022 13:03
@geropl geropl requested a review from a team November 9, 2022 13:03
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Nov 9, 2022
@roboquat roboquat merged commit 8f80612 into main Nov 9, 2022
@roboquat roboquat deleted the gpl/bm-ubp-free branch November 9, 2022 13:12
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note size/L team: webapp Issue belongs to the WebApp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[UBP] Usage-based users cannot see workspace classes after downgrading existing paid plans to Free
3 participants