Prevent workspaces from being OOM killed #14507
Conversation
|
started the job as gitpod-build-fo-oom-score.4 because the annotations in the pull request description changed |
| } | ||
| } | ||
|
|
||
| func (c *ProcessPriorityV2) adaptOOMScore(procType ProcessType, pid int64) { |
There was a problem hiding this comment.
Would it make sense to add 2 counters here:
- One for everytime the we try to adjust the OOM Score
- Another everytime we fail to adjust the OOM Score
There was a problem hiding this comment.
In this case I feel that just logging if we cannot adapt the oom score is enough.
| cgroup.ProcessWorkspaceKit: config.OOMScores.Tier1, | ||
| cgroup.ProcessSupervisor: config.OOMScores.Tier1, | ||
| cgroup.ProcessCodeServer: config.OOMScores.Tier1, | ||
| cgroup.ProcessIDE: config.OOMScores.Tier1, | ||
| cgroup.ProcessCodeServerHelper: config.OOMScores.Tier2, | ||
| cgroup.ProcessWebIDEHelper: config.OOMScores.Tier2, |
There was a problem hiding this comment.
@Furisto may I ask, did you socialize this improvement with the IDE team? I ask because it would make sense to get their feedback on this grouping and tier assignment.
There was a problem hiding this comment.
@gitpod-io/engineering-ide What do you think about this assignment? Tier 1 processes would not be oom killed with this change and for Tier 2 processes it is less likely. You can see how we identity the processes here.
|
@Furisto is this missing the |
|
@Furisto got it! Thank you 🙏 |
roboquat
added
the
deployed: workspace
Description
Prevent workspaces from being OOM killed. See the RFC for details.
Related Issue(s)
Fixes #13254
How to test
Release Notes
Werft options:
If enabled this will build
install/previewValid options are
all,workspace,webapp,ide