Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mount PVC as block device #14486

Closed
wants to merge 13 commits into from
Closed

mount PVC as block device #14486

wants to merge 13 commits into from

Conversation

sagor999
Copy link
Contributor

@sagor999 sagor999 commented Nov 7, 2022

Description

Mount PVC as block device.

Related Issue(s)

Fixes #13353

How to test

Release Notes

none

Documentation

Werft options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide

@roboquat roboquat added size/L and removed size/M labels Nov 8, 2022
@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-pavel-13353.4 because the annotations in the pull request description changed
(with .werft/ from main)

@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-pavel-13353.5 because the annotations in the pull request description changed
(with .werft/ from main)

Comment on lines 618 to +623
VolumeMounts: []corev1.VolumeMount{
{
Name: workspaceVolumeName,
SubPath: "workspace",
MountPath: "/workspace",
Name: "test",
MountPath: "/pvc",
},
},
Copy link
Contributor

@kylos101 kylos101 Nov 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This suggests that within a container, we should specify the device path, instead of the mount path, when mounting a PVC in volumeMode block.

See how in this example for a pod spec, there is no volumeMount?

If we do like ☝️ , I assume we'd then have to mount the device from workspacekit. 🤔

@stale
Copy link

stale bot commented Nov 22, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the meta: stale This issue/PR is stale and will be closed soon label Nov 22, 2022
@stale stale bot closed this Nov 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[PVC] loadgen testing Pod can't mount Volume
3 participants