[local-preview] Update status messages to depend on echo's #14391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the removal of `-x` option in bash, We can't rely on the commands anymore and instead have to start using `echo` messages to match statuses in `prettylog`. This PR updates the remaining statuses on the same. Signed-off-by: Tarun Pothulapati <[email protected]>
Pothulapati
changed the title
|
started the job as gitpod-build-tar-update-success-messages.1 because the annotations in the pull request description changed |
nandajavarma
approved these changes
Nov 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With the removal of
-xoption in bash, We can't rely on thecommands anymore and instead have to start using
echomessagesto match statuses in
prettylog.This PR updates the remaining statuses on the
same.
Signed-off-by: Tarun Pothulapati [email protected]
Related Issue(s)
Fixes #
How to test
Run
docker run -p 443:443 --privileged --name gitpod -it --mount type=volume,source=gitpod,destination=/var/gitpod eu.gcr.io/gitpod-core-dev/build/local-preview:tar-update-success-messages.1Release Notes
Documentation
Werft options:
If enabled this will build
install/previewValid options are
all,workspace,webapp,ide