Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JetBrains EAP] Add actions Copy URL and Copy Web URL to the terminal's ports context menu #14356

Merged
merged 1 commit into from
Nov 2, 2022

Conversation

felladrin
Copy link
Contributor

@felladrin felladrin commented Nov 2, 2022

Description

This PR enables the Port Forwarding Action initially implemented by @andreafalzetti.

When the user expands the "Forwared Port context menu" there's an option for copying the URL from that port:
image

  • Copy URL copies the forwarded URL (e.g. http://127.0.0.1:8000)
  • Copy Web URL copies the exposed URL (e.g. https://8000-gitpodio-gitpod-37qofs346l3.ws-eu73.gitpod.io)

The 'Copy Web URL' is also available in the non-forwared port context menu:
image

Note: The action is disabled when used from the Search Menu, and will only be displayed (greyed-out) if the user checks the "Include non-project items" box.

image

Related Issue(s)

Initially implemented in #13990

How to test

  1. In the Preview Environment of this PR, select IntelliJ EAP as your editor
  2. Start a workspace from https://github.com/gitpod-io/empty
  3. Open a terminal and run python -m http.server
  4. Observe that the port is automatically forwarded
  5. Click the forwarded port context menu and select "Copy URL" and confirm if the URL has been correctly copied to the clipboard
  6. Click the forwarded port context menu and select "Copy Web URL" and confirm if the URL has been correctly copied to the clipboard
  7. Click the non-forwarded port context menu and select "Copy Web URL" and confirm if the URL has been correctly copied to the clipboard

Release Notes

In JetBrains EAP IDEs, users now have the option to copy the URL from the terminal's ports context menu.

Werft options:

  • /werft with-preview
  • /werft with-large-vm

@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-jetbrains-copy-port-url-action.1 because the annotations in the pull request description changed
(with .werft/ from main)

@felladrin felladrin force-pushed the jetbrains/copy-port-url-action branch from d39d5d6 to 5501093 Compare November 2, 2022 15:09
…nals from JetBrains EAP IDEs

Co-authored-by: Andrea Falzetti <[email protected]>
Co-authored-by: Anton Kosyakov <[email protected]>
@felladrin felladrin force-pushed the jetbrains/copy-port-url-action branch from 5501093 to 31c0efe Compare November 2, 2022 16:15
@felladrin felladrin changed the title [JetBrains EAP] Add action Copy Port URL on forwarded ports in terminals [JetBrains EAP] Add actions Copy URL and Copy Web URL for forwarded ports in terminals Nov 2, 2022
@felladrin felladrin changed the title [JetBrains EAP] Add actions Copy URL and Copy Web URL for forwarded ports in terminals [JetBrains EAP] Add actions Copy URL and Copy Web URL to the terminal's ports context menu Nov 2, 2022
Copy link
Contributor

@andreafalzetti andreafalzetti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good work! thanks for adding this 🚀

tested and works as expected 👌

@roboquat roboquat merged commit 18aec45 into main Nov 2, 2022
@roboquat roboquat deleted the jetbrains/copy-port-url-action branch November 2, 2022 19:16
@roboquat roboquat added deployed: IDE IDE change is running in production deployed Change is completely running in production labels Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: IDE IDE change is running in production deployed Change is completely running in production editor: jetbrains release-note size/L team: IDE
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants