Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ws-daemon: Fix the problem with nice value not being applied #14111

Merged
merged 3 commits into from
Oct 24, 2022
Merged

ws-daemon: Fix the problem with nice value not being applied #14111

merged 3 commits into from
Oct 24, 2022

Conversation

utam0k
Copy link
Contributor

@utam0k utam0k commented Oct 24, 2022 •
edited by atduarte
Loading

Description

  • Add a handler when the workspace has gone
  • Fix the problem with nice value not being applied

Related Issue(s)

Relates: #14103
Fix: #11986

How to test

  1. Open a workspace
  2. Check if all target process are changed a nice value

Release Notes

Improved IDE startup time

Documentation

Werft options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide

@utam0k utam0k requested a review from a team October 24, 2022 06:57
@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-to-process-priority.9 because the annotations in the pull request description changed
(with .werft/ from main)

@github-actions github-actions bot added the team: workspace Issue belongs to the Workspace team label Oct 24, 2022
@sagor999 sagor999 force-pushed the to/process-priority branch from 13f1858 to 3e4f000 Compare October 24, 2022 14:28
@sagor999
Copy link
Contributor

@Furisto PTAL
Fixed nit, and fixed build failure.

@sagor999 sagor999 mentioned this pull request Oct 24, 2022
Closed
@roboquat roboquat merged commit 3a6fe3a into main Oct 24, 2022
@roboquat roboquat deleted the to/process-priority branch October 24, 2022 15:58
@nandajavarma nandajavarma restored the to/process-priority branch October 27, 2022 09:10
@nandajavarma nandajavarma deleted the to/process-priority branch October 27, 2022 09:12
@nandajavarma nandajavarma mentioned this pull request Oct 27, 2022
Merged
4 tasks
@roboquat roboquat added deployed: workspace Workspace team change is running in production deployed Change is completely running in production labels Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Furisto Furisto Furisto approved these changes

Assignees
No one assigned
Labels
deployed: workspace Workspace team change is running in production deployed Change is completely running in production release-note size/M team: workspace Issue belongs to the Workspace team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

process priority sometimes fails
4 participants
@utam0k @sagor999 @Furisto @roboquat