Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[server] remove port 3000 from default config #14056

Merged
merged 1 commit into from
Oct 20, 2022
Merged

[server] remove port 3000 from default config #14056

merged 1 commit into from
Oct 20, 2022

Conversation

mustard-mh
Copy link
Contributor

@mustard-mh mustard-mh commented Oct 20, 2022 •
edited by loujaybee
Loading

Description

Related Issue(s)

Fixes #
Fixes internal chat

How to test

Release Notes

Port 3000 not showing if no `.gitpod.yml` in project

Documentation

Werft options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide

@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-hw-df-port.1 because the annotations in the pull request description changed
(with .werft/ from main)

@mustard-mh
Copy link
Contributor Author

mustard-mh commented Oct 20, 2022 •
edited by werft-gitpod-dev-com bot
Loading

/werft run

👍 started the job as gitpod-build-hw-df-port.2
(with .werft/ from main)

@mustard-mh mustard-mh marked this pull request as ready for review October 20, 2022 19:22
@mustard-mh mustard-mh requested a review from a team October 20, 2022 19:22
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Oct 20, 2022
@easyCZ
Copy link
Member

easyCZ commented Oct 20, 2022

Looks like it's been there for 2 years - since b71f68f#diff-d26a92840b8fdcdeb54cc05627962891fbc4bbbe1f6872661f1e8a956f1d5600R161

Siddhant-K-code
Siddhant-K-code approved these changes Oct 20, 2022
View reviewed changes
Copy link
Member

@Siddhant-K-code Siddhant-K-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working Perfectly 💯 🚀

Old New
image image

:shipit:

@roboquat roboquat merged commit 91dea2e into main Oct 20, 2022
@roboquat roboquat deleted the hw/df-port branch October 20, 2022 20:24
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Siddhant-K-code Siddhant-K-code Siddhant-K-code approved these changes

@easyCZ easyCZ easyCZ approved these changes

Assignees
No one assigned
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note size/XS team: webapp Issue belongs to the WebApp team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mustard-mh @easyCZ @Siddhant-K-code @roboquat