Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update balance used progress indicator height #14054

Merged
merged 1 commit into from
Oct 20, 2022

Conversation

gtsiolis
Copy link
Contributor

@gtsiolis gtsiolis commented Oct 20, 2022

Description

This will update the progress indicator height in the billing page. See relevant discussion (internal).

Screenshots

BEFORE AFTER
Screenshot 2022-10-20 at 7 05 19 PM Screenshot 2022-10-20 at 7 05 33 PM

How to test

Go to usage for a personal account or a team.

Release Notes

Update usage-based billing balance used progress indicator height

Werft options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide

@gtsiolis gtsiolis requested a review from a team October 20, 2022 16:06
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Oct 20, 2022
@gtsiolis
Copy link
Contributor Author

gtsiolis commented Oct 20, 2022

/werft run with-preview with-payment

👍 started the job as gitpod-build-gt-update-progress-indicator-height.1
(with .werft/ from main)

@gtsiolis
Copy link
Contributor Author

@jankeromnes Could you take a look at this, since you were involved in the discussion linked in the PR description?

Feel free to close this if you think it's not improving the current state.

@gtsiolis gtsiolis requested a review from jankeromnes October 20, 2022 16:10
Copy link
Contributor

@jankeromnes jankeromnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks! I think this looks great. ✨ 😁

@roboquat roboquat merged commit 1aef59b into main Oct 20, 2022
@roboquat roboquat deleted the gt/update-progress-indicator-height branch October 20, 2022 16:26
@gtsiolis
Copy link
Contributor Author

gtsiolis commented Oct 20, 2022

Thanks for taking a look, @jankeromnes! 🍷

@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: dashboard deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note size/XS team: webapp Issue belongs to the WebApp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants