Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[server] Deprecate AdditionalContentPrefixContextParser #13841

Merged
merged 1 commit into from
Oct 14, 2022
Merged

[server] Deprecate AdditionalContentPrefixContextParser #13841

merged 1 commit into from
Oct 14, 2022

Conversation

geropl
Copy link
Member

@geropl geropl commented Oct 13, 2022 •
edited by loujaybee
Loading

Description

Deprecating AdditionalContentPrefixContextParser was mostly added for debugging purposes.

Related Issue(s)

Fixes #

How to test

Release Notes

NONE

Documentation

Werft options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide

@geropl geropl requested a review from a team October 13, 2022 13:07
@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-gpl-74-add-content.2 because the annotations in the pull request description changed
(with .werft/ from main)

@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Oct 13, 2022
@easyCZ
Copy link
Member

easyCZ commented Oct 13, 2022

/hold for Q

easyCZ
easyCZ approved these changes Oct 13, 2022
View reviewed changes
Copy link
Member

@easyCZ easyCZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not really a deprecation - it's a removal. Do you want to rephrase the release note?

@geropl
Copy link
Member Author

geropl commented Oct 14, 2022

It's not really a deprecation - it's a removal. Do you want to rephrase the release note?

✔️

/unhold

@roboquat roboquat merged commit ed62ab9 into main Oct 14, 2022
@roboquat roboquat deleted the gpl/74-add-content branch October 14, 2022 06:26
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@easyCZ easyCZ easyCZ approved these changes

Assignees
No one assigned
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note-none size/M team: webapp Issue belongs to the WebApp team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@geropl @easyCZ @roboquat