[bridge] Introduce AppClusterWorkspaceInstanceController #13831
Conversation
|
started the job as gitpod-build-gpl-6770-app-gc.2 because the annotations in the pull request description changed |
geropl
force-pushed
the
gpl/6770-app-gc
branch
3 times, most recently
from
76e0726 to
287cb5a
Compare
geropl
force-pushed
the
gpl/6770-app-gc
branch
from
287cb5a to
977c44d
Compare
| log.info("Controlling app cluster instances", { installation: appClusterInstallation }); | ||
|
|
||
| const notStoppedInstances = await this.workspaceDb.findRunningInstancesWithWorkspaces( | ||
| appClusterInstallation, | ||
| undefined, | ||
| false, | ||
| ); | ||
| await this.workspaceInstanceController.controlNotStoppedAppClusterManagedInstanceTimeouts( | ||
| ctx, | ||
| notStoppedInstances, | ||
| appClusterInstallation, | ||
| ); | ||
|
|
||
| log.info("Done controlling app cluster instances", { | ||
| installation: appClusterInstallation, | ||
| instancesCount: notStoppedInstances.length, | ||
| }); |
There was a problem hiding this comment.
Nice. This would be the perfect place to put any metrics which report duration & outcome. Shame we don't have metrics configured for ws-manager-bridge
There was a problem hiding this comment.
We could "cheat" and attach the duration of the run (and any outcome) to the log fields.
|
|
||
| @inject(WorkspaceDB) protected readonly workspaceDb: WorkspaceDB; | ||
|
|
||
| @inject(WorkspaceInstanceController) protected readonly workspaceInstanceController: WorkspaceInstanceController; |
There was a problem hiding this comment.
Would we eventually move this instance onto this controller also? Seems we've got layers here which may not be adding immediate value.
There was a problem hiding this comment.
Yeah, we could! It's basically and artifact of splitting the PRs, and not adjusting after the rebase 😆
roboquat
added
deployed: webapp
Description
Introduces
AppClusterWorkspaceInstanceControllerto garbage-collect workspace instance that failed to start on the application cluster side of the instance lifecycle:Related Issue(s)
Prerequisite: #13866
Contributes to: #6770
How to test
Release Notes
Documentation
Werft options:
If enabled this will build
install/previewValid options are
all,workspace,webapp,ide