Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the auto-port-forwarding on JetBrains EAP IDEs #13747

Merged
merged 1 commit into from
Oct 13, 2022

Conversation

felladrin
Copy link
Contributor

@felladrin felladrin commented Oct 11, 2022

Description

Now that we have EAP IDEs build 223.6x available in gitpod.io, we need to update the back-end plugin with the support for the new Port Forwarding API.

In the current state of this PR, the plugin compiles and makes the auto-forwarding work again for EAP IDEs.

In a follow-up PR we should:

  • Ensure the usage of port name/description columns is working.
  • Remove the unused function overrides from object: ForwardedPortListener.
  • Confirm there's no other way to dispose the forwarded ports listeners (currently we use a map for it).
  • Confirm if ports are removed from the UI when programatically removed.

Related Issue(s)

How to test

  1. Open the preview environment of this PR: https://jetbrains-d939b7c0c7.preview.gitpod-dev.com/workspaces
  2. In the account preferences, select the Latest JetBrains IntelliJ IDEA as the editor
  3. Start a workspace from https://github.com/gitpod-io/spring-petclinic and check if it there's no error triggered.
  4. Open a new terminal and check if when running python3 -m http.server 2593 it automatically forwards the server port, so you're able to access http://127.0.0.1:2593
    image
  5. Don't worry about "Control Center >> Ports" view at this moment. We'll need to learn more about the new API before properly controlling it. It should be done in a follow-up PR.

Release Notes

Fixed auto-port-forwarding on JetBrains EAP IDEs

Werft options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide

@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-jetbrains-port-forwarding.1 because the annotations in the pull request description changed
(with .werft/ from main)

@felladrin felladrin changed the title Adjust JetBrains Backend Plugin to work with the new Port Forwarding API Fix the auto-port-forwarding on JetBrains EAP IDEs Oct 11, 2022
@felladrin felladrin self-assigned this Oct 11, 2022
@felladrin felladrin marked this pull request as ready for review October 11, 2022 09:43
@felladrin felladrin requested a review from a team October 11, 2022 09:43
Copy link
Contributor

@andreafalzetti andreafalzetti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected ✅

We also did review the code together 🚀

@roboquat roboquat merged commit 7f45780 into main Oct 13, 2022
@roboquat roboquat deleted the jetbrains/port-forwarding branch October 13, 2022 15:18
@roboquat roboquat added deployed: IDE IDE change is running in production deployed Change is completely running in production labels Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: IDE IDE change is running in production deployed Change is completely running in production editor: jetbrains release-note size/L team: IDE
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automatic Port Forwarding stopped working on JetBrains EAP IDEs
3 participants