Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitbucket-server] fix parsing of branch name #13745

Merged
merged 1 commit into from
Oct 11, 2022
Merged

Conversation

AlexTugarev
Copy link
Member

Context URLs of BitBucket Server may include a search param "at" to specify a branch fully qualified. GItpod's context parser results are expected to provide a simple "ref" name for branches.

This PR fixes parsing of branch names.

Related Issue(s)

Fixes #13486

How to test

Rerun unit test

cd components/server
npx mocha --opts mocha.opts /workspace/gitpod/components/server/src/bitbucket-server/bitbucket-server-context-parser.spec.ts

Release Notes

Fix branch context for BitBucket Server

Documentation

Werft options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide

Context URLs of BitBucket Server may include a search param "at" to specify a branch fully qualified. GItpod's context parser results are expected to provide a simple "ref" name for branches.
@AlexTugarev AlexTugarev requested a review from a team October 11, 2022 08:45
@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-at-bbs-fix-branch-context.2 because the annotations in the pull request description changed
(with .werft/ from main)

@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Oct 11, 2022
@easyCZ
Copy link
Member

easyCZ commented Oct 11, 2022

Thanks for the test!

@roboquat roboquat merged commit 542e7c9 into main Oct 11, 2022
@roboquat roboquat deleted the at/bbs-fix-branch-context branch October 11, 2022 08:59
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note size/S team: webapp Issue belongs to the WebApp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BitbucketServer] Prebuilds are broken on branch context
3 participants