-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add .tar extension to downloaded workspace #13678
Conversation
started the job as gitpod-build-tar-file-ext.0 because the annotations in the pull request description changed |
started the job as gitpod-build-tar-file-ext.1 because the annotations in the pull request description changed |
/werft with-clean-slate-deployment 👎 unknown command: with-clean-slate-deployment |
/werft run with-clean-slate-deployment 👍 started the job as gitpod-build-tar-file-ext-fork.0 |
/werft run with-clean-slate-deployment 👍 started the job as gitpod-build-tar-file-ext-fork.1 |
started the job as gitpod-build-tar-file-ext.2 because the annotations in the pull request description changed |
/werft run 👍 started the job as gitpod-build-tar-file-ext-fork.2 |
I think the job with the preview env was failing due to it being from a fork. I've launched it manually and you can access the preview envs' workspace here. If you are happy with the results, feel free to remove the hold label 😄 |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
not stale 🙏 |
@ghostdevv you should be able to merge this when you're ready by removing the `do-not-merge/hold' label. |
Thanks! |
Description
Currently when downloading a workspace it misses the
.tar
file extension. This uses the html nativedownload
property to add the.tar
extensionRelated Issue(s)
Fixes #7955
How to test
(taken from #7955)
Download Workspace
Release Notes
Documentation
Werft options:
If enabled this will build
install/preview
Valid options are
all
,workspace
,webapp
,ide