Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .tar extension to downloaded workspace #13678

Merged
merged 1 commit into from
Oct 31, 2022

Conversation

ghostdevv
Copy link
Contributor

@ghostdevv ghostdevv commented Oct 7, 2022

Description

Currently when downloading a workspace it misses the .tar file extension. This uses the html native download property to add the .tar extension

Related Issue(s)

Fixes #7955

How to test

(taken from #7955)

Release Notes

Fixed missing .tar file extension from a downloaded workspace

Documentation

Werft options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide

@ghostdevv ghostdevv requested a review from a team October 7, 2022 11:25
@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-tar-file-ext.0 because the annotations in the pull request description changed
(with .werft/ from main)

@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-tar-file-ext.1 because the annotations in the pull request description changed
(with .werft/ from main)

@laushinka
Copy link
Contributor

laushinka commented Oct 12, 2022

/werft with-clean-slate-deployment

👎 unknown command: with-clean-slate-deployment
Use /werft help to list the available commands

@laushinka
Copy link
Contributor

laushinka commented Oct 12, 2022

/werft run with-clean-slate-deployment

👍 started the job as gitpod-build-tar-file-ext-fork.0
(with .werft/ from main)

@vulkoingim
Copy link
Contributor

vulkoingim commented Oct 12, 2022

/werft run with-clean-slate-deployment

👍 started the job as gitpod-build-tar-file-ext-fork.1
(with .werft/ from main)

@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-tar-file-ext.2 because the annotations in the pull request description changed
(with .werft/ from main)

@vulkoingim
Copy link
Contributor

vulkoingim commented Oct 13, 2022

/werft run

👍 started the job as gitpod-build-tar-file-ext-fork.2
(with .werft/ from main)

@vulkoingim
Copy link
Contributor

vulkoingim commented Oct 13, 2022

I think the job with the preview env was failing due to it being from a fork.

I've launched it manually and you can access the preview envs' workspace here.

If you are happy with the results, feel free to remove the hold label 😄

@stale
Copy link

stale bot commented Oct 28, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the meta: stale This issue/PR is stale and will be closed soon label Oct 28, 2022
@ghostdevv
Copy link
Contributor Author

not stale 🙏

@stale stale bot removed the meta: stale This issue/PR is stale and will be closed soon label Oct 31, 2022
@andrew-farries
Copy link
Contributor

@ghostdevv you should be able to merge this when you're ready by removing the `do-not-merge/hold' label.

@roboquat roboquat merged commit 262b6e0 into gitpod-io:main Oct 31, 2022
@ghostdevv
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Downloaded workspace file does not have any valid file extension specified
5 participants