Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dashboard] Fetch user BillingMode on load (or team change) #13621

Merged
merged 1 commit into from
Oct 6, 2022

Conversation

geropl
Copy link
Member

@geropl geropl commented Oct 5, 2022

Description

With a recent change we stopped fetching BillingMode, which results in us not rendering menu entries to Personal (/plans) or Team (/teams) billing pages. This PR fixes that by fetching on load of the page.

Related Issue(s)

Fixes #13618

How to test

Release Notes

Fix rendering Personal/Team billing menu entries

Documentation

Werft options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-payment
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide

@geropl geropl requested a review from a team October 5, 2022 14:59
@geropl
Copy link
Member Author

geropl commented Oct 5, 2022

/hold for testing in preview

@geropl
Copy link
Member Author

geropl commented Oct 5, 2022

/werft run

👍 started the job as gitpod-build-gpl-fix-plans-ui.3
(with .werft/ from main)

@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Oct 5, 2022
@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-gpl-fix-plans-ui.2 because the annotations in the pull request description changed
(with .werft/ from main)

@geropl
Copy link
Member Author

geropl commented Oct 5, 2022

Seems to work for me:
image

@geropl
Copy link
Member Author

geropl commented Oct 5, 2022

/werft run

👍 started the job as gitpod-build-gpl-fix-plans-ui.4
(with .werft/ from main)

to make GitHub checks happy...

Copy link
Contributor

@laushinka laushinka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as advertised!

@geropl
Copy link
Member Author

geropl commented Oct 6, 2022

/unhold

@roboquat roboquat merged commit 2b216c0 into main Oct 6, 2022
@roboquat roboquat deleted the gpl/fix-plans-ui branch October 6, 2022 07:17
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note size/XS team: webapp Issue belongs to the WebApp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Users can no longer access or use the team plans or plans page
3 participants