Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build stable image for VS Code Browser 1.72 #13617

Merged
merged 1 commit into from
Oct 7, 2022
Merged

Conversation

filiptronicek
Copy link
Member

@filiptronicek filiptronicek commented Oct 5, 2022

Description

Update code to 1.72.0

How to test

  • Switch to VS Code Insiders in settings.
  • Start a workspace.
  • Test following:
    • terminals are preserved and resized properly between window reloads
    • WebViews are working
    • extension host process: check language smartness and debugging
    • extension management (installing/uninstalling)
    • install the VIM extension to test web extensions
    • that user data is synced across workspaces as well as on workspace restarts, especially for extensions
      • extensions from .gitpod.yml are not installed as sync
      • extensions installed as sync are actually synced to all new workspaces
    • settings should not contain any mentions of MS telemetry
    • WebSockets and workers are properly proxied
      • diff editor should be operatable
      • trigger reconnection with window.WebSocket.disconnectWorkspace(), check that old WebSockets are closed and new opened of the same amount
    • workspace specific commands should work, i.e. F1 → type Gitpod prefix
    • that a PR view is preloaded on the PR URL
    • test gp open and gp preview
    • test open in VS Code Desktop, check gp open and gp preview in task/user terminals
    • telemetry data is collected in Segment

Release Notes

Release VS Code Browser `1.72`

Werft options:

  • /werft with-preview
  • /werft analytics=segment|TEZnsG4QbLSxLfHfNieLYGF4cDwyFWoe

@filiptronicek
Copy link
Member Author

filiptronicek commented Oct 5, 2022

/werft run with-clean-slate

👍 started the job as gitpod-build-code-insiders-1.72.5
(with .werft/ from main)

@filiptronicek
Copy link
Member Author

filiptronicek commented Oct 6, 2022

/werft run

👍 started the job as gitpod-build-code-insiders-1.72.6
(with .werft/ from main)

@filiptronicek
Copy link
Member Author

filiptronicek commented Oct 6, 2022

/werft run with-preview with-clean-slate-deployment

👍 started the job as gitpod-build-code-insiders-1.72.7
(with .werft/ from main)

@filiptronicek
Copy link
Member Author

filiptronicek commented Oct 6, 2022

/werft run with-preview with-clean-slate-deployment

👍 started the job as gitpod-build-code-insiders-1.72.9
(with .werft/ from main)

@jeanp413 jeanp413 self-requested a review October 7, 2022 04:25
@akosyakov
Copy link
Member

release notes none?

@filiptronicek
Copy link
Member Author

release notes none?

Wasn't sure about whether we decided officially to include it (just a couple versions back, we didn't), will add it.

@jeanp413
Copy link
Member

jeanp413 commented Oct 7, 2022

@filiptronicek good to go, extension sync is working,
P.S.: I couldn't test test open in VS Code Desktop something is wrong with prev env (not related to vscode) that cannot connect to ssh , so I would say just skip it.

@filiptronicek
Copy link
Member Author

/hold

@filiptronicek
Copy link
Member Author

filiptronicek commented Oct 7, 2022

Thanks @jeanp413 for looking into it and fixing the issue 🙏, will raise the follow up PR soon and request a review from you again if that's alright.

@filiptronicek
Copy link
Member Author

/unhold

@roboquat roboquat merged commit ed5f712 into main Oct 7, 2022
@roboquat roboquat deleted the code-insiders-1.72 branch October 7, 2022 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants