Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(gitpod-cli): Update top table output format #13607

Merged
merged 2 commits into from
Oct 5, 2022

Conversation

WVerlaek
Copy link
Member

@WVerlaek WVerlaek commented Oct 5, 2022

Description

Updates gp top table output to match gp info, follow up from discussion in #13537 (comment).

Also moves the workspace class to the table. Alternatively we could remove the workspace class from the output, as it's also shown in gp info now. Personally I think it'd be nice to keep it in gp top as well as it's relevant info, and it would be a breaking change to remove it from e.g. the --json output.

Original:
image

New:
image

Related Issue(s)

Fixes #

How to test

Release Notes

`gp top` table output updated to match `gp info`

Documentation

Werft options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide

Copy link
Contributor

@andreafalzetti andreafalzetti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The output is now much easier to read IMO, thanks a lot! 🙌

+1 also on your point about removing the workspace class, makes sense to keep it 💯

@roboquat roboquat merged commit 3684e89 into main Oct 5, 2022
@roboquat roboquat deleted the wverlaek/update-top-table-output branch October 5, 2022 14:32
@roboquat roboquat added deployed: IDE IDE change is running in production deployed Change is completely running in production labels Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: gp cli deployed: IDE IDE change is running in production deployed Change is completely running in production release-note size/M team: IDE
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants