Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dashboard] Deprecate the creation of projects under individual accounts #13414

Merged
merged 1 commit into from
Oct 5, 2022
Merged

[dashboard] Deprecate the creation of projects under individual accounts #13414

merged 1 commit into from
Oct 5, 2022

Conversation

svenefftinge
Copy link
Member

@svenefftinge svenefftinge commented Sep 28, 2022 •
edited by jldec
Loading

Description

A quick prototype of how to simplify user accounts by removing the ability to create projects which belong to an individual account instead of a team, and moving the workspaces list to the left side of the nav bar.

https://www.loom.com/share/b5d8544f7a864912a9d75ba04e921dc8

Related Issue(s)

Fixes #14035

How to test

Release Notes

Deprecation of the ability to create projects under an individual account for new users.

Documentation

Werft options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide

@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-se-no-indi.2 because the annotations in the pull request description changed
(with .werft/ from main)

@roboquat roboquat added size/L and removed size/XS labels Sep 28, 2022
@svenefftinge svenefftinge changed the title wip [wip] Deprecate individual accounts Sep 28, 2022
@svenefftinge
Copy link
Member Author

svenefftinge commented Oct 3, 2022 •
edited by werft-gitpod-dev-com bot
Loading

/werft run

👍 started the job as gitpod-build-se-no-indi.5
(with .werft/ from main)

@roboquat roboquat added size/XS and removed size/L labels Oct 4, 2022
@svenefftinge svenefftinge reopened this Oct 4, 2022
@svenefftinge svenefftinge changed the title [wip] Deprecate individual accounts [dashboard] Deprecate individual accounts Oct 4, 2022
@gtsiolis
Copy link
Contributor

gtsiolis commented Oct 4, 2022 •
edited by werft-gitpod-dev-com bot
Loading

/werft run

👍 started the job as gitpod-build-se-no-indi.8
(with .werft/ from main)

@roboquat roboquat added size/XL and removed size/L labels Oct 4, 2022
@svenefftinge svenefftinge marked this pull request as ready for review October 4, 2022 11:29
@svenefftinge svenefftinge requested a review from a team October 4, 2022 11:29
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Oct 4, 2022
@jldec jldec changed the title [dashboard] Deprecate individual accounts [dashboard] Deprecate the creation of projects under individual accounts Oct 4, 2022
@jldec
Copy link
Contributor

jldec commented Oct 4, 2022

I like this simplification of where projects can live for the following reasons:

  • A project under a user account cannot not be shared, and its URL only works for that user.
  • Teams are a more flexible container for business use cases e.g. to manage ownership and billing

@gtsiolis
Copy link
Contributor

gtsiolis commented Oct 4, 2022 •
edited by werft-gitpod-dev-com bot
Loading

Looking at this now! 👀

gtsiolis
gtsiolis approved these changes Oct 4, 2022
View reviewed changes
Copy link
Contributor

@gtsiolis gtsiolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UX LGTM! ✔️

Left some minor design feedback and general thoughts.

components/dashboard/src/Menu.tsx Show resolved Hide resolved
components/dashboard/src/Menu.tsx Outdated Show resolved Hide resolved
components/dashboard/src/Menu.tsx Outdated Show resolved Hide resolved
components/dashboard/src/Menu.tsx Show resolved Hide resolved
components/dashboard/src/Menu.tsx Show resolved Hide resolved
components/dashboard/src/Menu.tsx Outdated Show resolved Hide resolved
components/dashboard/src/Menu.tsx Show resolved Hide resolved
components/dashboard/src/Menu.tsx Show resolved Hide resolved
easyCZ
easyCZ approved these changes Oct 5, 2022
View reviewed changes
Copy link
Member

@easyCZ easyCZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the loom

@roboquat roboquat merged commit 2d68f0f into main Oct 5, 2022
@roboquat roboquat deleted the se/no-indi branch October 5, 2022 07:11
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Oct 5, 2022
@gtsiolis gtsiolis mentioned this pull request Oct 6, 2022
Merged
4 tasks
This was referenced Oct 16, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@easyCZ easyCZ easyCZ approved these changes

@gtsiolis gtsiolis gtsiolis approved these changes

Assignees
No one assigned
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note size/XL team: webapp Issue belongs to the WebApp team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Epic: Deprecate projects under personal accounts
5 participants
@svenefftinge @gtsiolis @jldec @easyCZ @roboquat