[local-preview] Failure with more specific information #13403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
started the job as gitpod-build-tar-lp-better-failure.1 because the annotations in the pull request description changed |
Pothulapati
force-pushed
the
tar/lp-better-failure
branch
3 times, most recently
from
b61d612 to
0f8ab00
Compare
Currently, When there is a failure at `checking_prerequisites` we don't actually propogate the issue resulting in confusion to the users. This PR updates the prettylog script to propogate the same as an error for the user to get more information Signed-off-by: Tarun Pothulapati <[email protected]>
Pothulapati
force-pushed
the
tar/lp-better-failure
branch
from
0f8ab00 to
5c1dcc0
Compare
github-actions
bot
added
the
team: delivery
mrsimonemms
approved these changes
Sep 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, When there is a failure at
checking_prerequisiteswe don't actually propogate the issue resulting in confusion to the users. This PR updates the prettylog script to propogate the same as an error for the user to get more informationSigned-off-by: Tarun Pothulapati [email protected]
Related Issue(s)
Part of #11316
How to test
Run
on a system with low resources
Release Notes
Documentation
Werft options:
If enabled this will build
install/previewValid options are
all,workspace,webapp,ide