[ws-manager] refactor ide image layer and envvar #13387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roboquat
added
do-not-merge/work-in-progress
release-note-none
size/L
size/XXL
and removed
size/L
labels
iQQBot
force-pushed
the
pd/wsm-proto
branch
4 times, most recently
from
9cb86d8 to
1c6a4c4
Compare
csweichel
reviewed
Sep 28, 2022
iQQBot
force-pushed
the
pd/wsm-proto
branch
3 times, most recently
from
69184f1 to
dcc6377
Compare
github-actions
bot
added
team: webapp
|
/hold need delete test commit |
csweichel
reviewed
Sep 28, 2022
csweichel
reviewed
Sep 28, 2022
csweichel
reviewed
Sep 28, 2022
iQQBot
force-pushed
the
pd/wsm-proto
branch
2 times, most recently
from
cae7b78 to
f0d8c7a
Compare
|
/werft run with-clean-slate-deployment=true 👍 started the job as gitpod-build-pd-wsm-proto.14 |
iQQBot
force-pushed
the
pd/wsm-proto
branch
from
f0d8c7a to
ed5589a
Compare
|
Hi @csweichel I already changed the code, could you please take a look again 🙏 |
sagor999
approved these changes
Sep 28, 2022
iQQBot
force-pushed
the
pd/wsm-proto
branch
from
ed5589a to
209ba59
Compare
easyCZ
approved these changes
Sep 30, 2022
aledbf
approved these changes
Oct 4, 2022
geropl
reviewed
Oct 5, 2022
|
Hi @csweichel , we want to merge it today, it would be good if you can review it again, thanks 🙏 |
csweichel
approved these changes
Oct 13, 2022
|
started the job as gitpod-build-pd-wsm-proto.18 because the annotations in the pull request description changed |
|
/unhold |
|
/werft run 👍 started the job as gitpod-build-pd-wsm-proto.20 |
roboquat
added
deployed: workspace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We want to decouple the IDE component from the
ws-managerIn the past, if we needed to add an environment variable starting with
GITPOD, we needed to modify the whitelist ofws-managerfirst, and then wait for the workspace team to deployed the new generation cluster before we could modify the server, in this PR, thesystem variablesare distinguished from theuser-defined environment variables, thesystem variablesare not filtered, and No need to write secretAnother case is if we want to add another layer of images to the IDE, the situation is the same as above, we have to modify the
registry-facadeandws-managerand wait for the workspace team to deploy it, in this PR, we add a new ide_layer_ref which is contain some ide image layer, later if we want to add layers later, we can dynamically addRelated Issue(s)
Relate #9189
How to test
serverimage toeu.gcr.io/gitpod-core-dev/build/server:main.4899and test step 1, it should work tooRelease Notes
Documentation
Werft options:
If enabled this will build
install/previewValid options are
all,workspace,webapp,ide