Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: update test TestOpenWorkspaceFromPrebuild #13371

Merged
merged 1 commit into from
Sep 29, 2022
Merged

test: update test TestOpenWorkspaceFromPrebuild #13371

merged 1 commit into from
Sep 29, 2022

Conversation

jenting
Copy link
Contributor

@jenting jenting commented Sep 27, 2022 •
edited
Loading

Description

Update test TestOpenWorkspaceFromPrebuild to check whether the PVC object should exist or not.

Related Issue(s)

Partially #12638

How to test

Run the workspace integration test.

cd test

go test -run ^TestOpenWorkspaceFromPrebuild$ github.com/gitpod-io/gitpod/test/tests/components/ws-manager -count=1 -namespace=default -kubeconfig=/home/gitpod/.kube/config -v -timeout=20m

Release Notes

None

Documentation

None

Werft options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-integration-tests=workspace
    Valid options are all, workspace, webapp, ide

@jenting jenting force-pushed the jenting/12638-case2 branch from 966a262 to 791cb4b Compare September 27, 2022 13:52
@jenting jenting changed the title test: add new test TestPrebuildDisablePVCAndEnablePVCOnExistingProject test: update test TestOpenWorkspaceFromPrebuild Sep 27, 2022
@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-jenting-12638-case2.9 because the annotations in the pull request description changed
(with .werft/ from main)

@jenting jenting force-pushed the jenting/12638-case2 branch from 791cb4b to 3832968 Compare September 27, 2022 14:28
@jenting jenting marked this pull request as ready for review September 27, 2022 14:29
@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-jenting-12638-case2.11 because the annotations in the pull request description changed
(with .werft/ from main)

@jenting jenting mentioned this pull request Sep 27, 2022
Closed
6 tasks
@jenting jenting marked this pull request as draft September 28, 2022 03:05
@jenting jenting force-pushed the jenting/12638-case2 branch from 3832968 to 0e1e69d Compare September 28, 2022 04:09
@jenting jenting marked this pull request as ready for review September 28, 2022 05:21
@jenting jenting requested a review from a team September 28, 2022 05:21
@github-actions github-actions bot added the team: workspace Issue belongs to the Workspace team label Sep 28, 2022
@jenting jenting force-pushed the jenting/12638-case2 branch 2 times, most recently from 17843c1 to 176806a Compare September 28, 2022 07:51
@roboquat roboquat added size/M and removed size/L labels Sep 28, 2022
@jenting
Copy link
Contributor Author

jenting commented Sep 28, 2022 •
edited by werft-gitpod-dev-com bot
Loading

/werft run with-large-vm

👍 started the job as gitpod-build-jenting-12638-case2.15
(with .werft/ from main)

@geropl
Copy link
Member

geropl commented Sep 28, 2022

/hold blocking merge queue, not sure why. Maybe the long-running build? 🤔

@jenting
Copy link
Contributor Author

jenting commented Sep 28, 2022 •
edited by werft-gitpod-dev-com bot
Loading

/werft run with-large-vm

👍 started the job as gitpod-build-jenting-12638-case2.16
(with .werft/ from main)

@jenting jenting marked this pull request as draft September 28, 2022 12:17
@jenting jenting force-pushed the jenting/12638-case2 branch from 176806a to c1fe06b Compare September 28, 2022 12:19
@jenting jenting force-pushed the jenting/12638-case2 branch from c1fe06b to 7e57252 Compare September 29, 2022 01:19
@jenting
test: update TestOpenWorkspaceFromPrebuild
6e8efd1 
Check the PVC object should exist or not.

Signed-off-by: JenTing Hsiao <[email protected]>
@jenting jenting force-pushed the jenting/12638-case2 branch from 7e57252 to 6e8efd1 Compare September 29, 2022 04:46
@jenting jenting marked this pull request as ready for review September 29, 2022 06:04
@jenting
Copy link
Contributor Author

jenting commented Sep 29, 2022

/unhold

@roboquat roboquat merged commit d2eca2b into main Sep 29, 2022
@roboquat roboquat deleted the jenting/12638-case2 branch September 29, 2022 06:05
@roboquat roboquat added deployed: workspace Workspace team change is running in production deployed Change is completely running in production labels Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Furisto Furisto Furisto approved these changes

Assignees
No one assigned
Labels
deployed: workspace Workspace team change is running in production deployed Change is completely running in production release-note-none size/M team: workspace Issue belongs to the Workspace team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jenting @geropl @Furisto @roboquat