Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dashboard] keep team selection #13318

Merged
merged 1 commit into from
Sep 28, 2022
Merged

[dashboard] keep team selection #13318

merged 1 commit into from
Sep 28, 2022

Conversation

svenefftinge
Copy link
Member

@svenefftinge svenefftinge commented Sep 26, 2022 •
edited
Loading

Description

This PR changes remembers the selection of the team, so that it doesn't jump back to the individual account whenever I visit the workspaces list.

Related Issue(s)

Fixes #10496

How to test

Use the preview App and verify the promised behavior.

Release Notes

Keep the last selected team selected

Documentation

Werft options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide

@gtsiolis
Copy link
Contributor

@svenefftinge See also #10496 and #10603, in case they contain any useful information or we can close as duplicates.

@roboquat roboquat added size/M and removed size/S labels Sep 26, 2022
@svenefftinge svenefftinge force-pushed the se/team-selection branch 4 times, most recently from 169b5a4 to dabd407 Compare September 27, 2022 04:26
@svenefftinge svenefftinge marked this pull request as ready for review September 27, 2022 06:54
@svenefftinge svenefftinge requested a review from a team September 27, 2022 06:54
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Sep 27, 2022
gtsiolis
gtsiolis reviewed Sep 27, 2022
View reviewed changes
Copy link
Contributor

@gtsiolis gtsiolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dropping below two UX issues.

components/dashboard/src/Menu.tsx
<span
className={`${classes} rounded-tl-2xl rounded-bl-2xl border-r pl-3 pr-2 py-1 bg-gray-50 font-semibold`}
>
{teams?.find((t) => t.slug === getSelectedTeamSlug())?.name || userFullName}
Copy link
Contributor

@gtsiolis gtsiolis Sep 27, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue: I can no longer select personal account, although you get redirected to the projects of the personal account when you select your personal account from the dropdown. 😭

components/dashboard/src/Menu.tsx
<span
className={`${classes} rounded-tl-2xl rounded-bl-2xl border-r pl-3 pr-2 py-1 bg-gray-50 font-semibold`}
>
{teams?.find((t) => t.slug === getSelectedTeamSlug())?.name || userFullName}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue: Going from workspaces back to the team-scope always goes back to the personal account projects, regardless what the selected team scope is. This should get you back to the projects of the last selected team, right?

@laushinka
Copy link
Contributor

laushinka commented Sep 27, 2022 •
edited
Loading

Thanks for this, @svenefftinge! The team persistence works well, but too well :P I can switch between teams but unable to go back to my personal account. Probably team-selection needs to be removed from local storage when selecting the personal account?
Update: Just saw George report the same thing.

@svenefftinge svenefftinge marked this pull request as draft September 27, 2022 15:56
@svenefftinge
Copy link
Member Author

svenefftinge commented Sep 28, 2022 •
edited by werft-gitpod-dev-com bot
Loading

/werft run with-clean-slate-deployment=true

👍 started the job as gitpod-build-se-team-selection.8
(with .werft/ from main)

@svenefftinge svenefftinge marked this pull request as ready for review September 28, 2022 09:53
laushinka
laushinka approved these changes Sep 28, 2022
View reviewed changes
Copy link
Contributor

@laushinka laushinka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as advertised!

@roboquat roboquat merged commit 5cf2cb8 into main Sep 28, 2022
@roboquat roboquat deleted the se/team-selection branch September 28, 2022 09:59
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gtsiolis gtsiolis gtsiolis left review comments

@laushinka laushinka laushinka approved these changes

Assignees
No one assigned
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note size/M team: webapp Issue belongs to the WebApp team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consider remembering team selection when visiting pages like workspaces
4 participants
@svenefftinge @gtsiolis @laushinka @roboquat