-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[single-cluster/aws] make self-signed
work
#13305
Conversation
69b2202
to
94944b0
Compare
Fixes #12979 This PR adds a new `post_bootstrap_user_data` variable to the EKS terraform modules that changes the containerd config to accept new self signed SSL Certificates, and restarting `containerd` to make the same work. Signed-off-by: Tarun Pothulapati <[email protected]>
94944b0
to
c2a4a37
Compare
3aed7b2
to
2a12ea9
Compare
@@ -89,6 +89,8 @@ pod: | |||
value: "/mnt/secrets/sh-playground-sa-perm/sh-sa.json" | |||
- name: TF_VAR_dns_sa_creds | |||
value: "/mnt/secrets/sh-playground-dns-perm/sh-dns-sa.json" | |||
- name: TF_VAR_sa_creds |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an unrelated change required to re-use the same environment while running tests! Context: https://gitpod.slack.com/archives/C01KLC56NP7/p1664268857397169?thread_ts=1664261197.651119&cid=C01KLC56NP7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a small cleanup command is necessary. This is a nit but can go long way in keeping the cloud storage clean.
/hold merge at your discretion
Would you also consider adding a doc for this to the internal notion page. The page doesn't have the most easiest structure right now but having it there would be great!
@@ -314,6 +314,9 @@ self-signed-config: | |||
envsubst < ./manifests/kots-config-self-signed.yaml > tmp_2_config.yml | |||
yq m -i tmp_config.yml tmp_2_config.yml | |||
|
|||
# upload the Custom CA Cert into tf-state |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also add commands to delete this file upon cleanup? It can be in this target if you would like.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added it to destroy-kubeconfig
, Do you think we should do it separately? 🤔
Signed-off-by: Tarun Pothulapati <[email protected]>
2a12ea9
to
523110a
Compare
/unhold |
Description
This PR adds a new
post_bootstrap_user_data
variable to the EKS terraform modules that changes the containerd config to accept new self signed SSL Certificates, and restartingcontainerd
to make the same work.This PR also changes the
self-signed
of infra tests to upload the CA certificate into gcs for us to download and use.Signed-off-by: Tarun Pothulapati [email protected]
Related Issue(s)
Fixes #12979
How to test
Run
or use the
self-signed
instance athttps://f0761-aws.tests.doptig.com
while using the certificate from https://werft.gitpod-dev.com/job/gitpod-custom-tar-eks-selfsigned.6/resultsRelease Notes
Documentation
Werft options:
If enabled this will build
install/preview
Valid options are
all
,workspace
,webapp
,ide