Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kots]: ensure log-collector directory on node at startup #13233

Merged
merged 1 commit into from
Sep 23, 2022

Conversation

mrsimonemms
Copy link
Contributor

Description

This ensures that the /gitpod/log-collector directory exists on every node at FluentBit startup. Previously, this directory was only created when a log was added which meant that the log-collector section in a support bundle was full of configmap-errors saying that the directory didn't exist.

Now, this only adds files into the support bundle if there are files to add, meaning that it's much easier to search for things to look through.

Related Issue(s)

Fixes #13095

How to test

Install via KOTS and generate a support bundle

Release Notes

[kots]: ensure log-collector directory on node at startup

Documentation

Werft options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide

Copy link
Contributor

@Pothulapati Pothulapati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't tested on GKE specifically but did it on k3s, and I don't see any config errors.

@roboquat roboquat merged commit 6e05a19 into main Sep 23, 2022
@roboquat roboquat deleted the sje/kots-log-collector branch September 23, 2022 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note size/XS team: delivery Issue belongs to the self-hosted team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[self-hosted] 20022.08.0 support bundle does not contain pod logs
3 participants